feat!: integrate cosmwasm #3051

Reecepbcups · 2024-04-09T23:05:26Z

Adds CosmWasm and makes it permissioned in the upgrade handler per proposal 895 signaling to add.

Test Local node Script

# The testnode here is permissionless. On upgrade handler, permissioned is set
GAIAD_NODE=http://localhost:26657
rm -rf ~/.gaia/ && make install
sh contrib/single-node.sh local-1 cosmos10r39fueph9fq7a6lgswu4zdsg8t3gxlqvvvyvn

Upload Wasm Contract

sh ./contrib/upload-contract.sh

Local Upgrade

go install github.com/cosmos/cosmos-sdk/cosmovisor/cmd/cosmovisor@latest
GAIAD_NODE=http://localhost:26657

git checkout v15.1.0
make build
cp ./build/gaiad ./build/gaiadold
go clean -modcache

git checkout wasmd-integration
make build
cp ./build/gaiad ./build/gaiadnew

./contrib/scripts/upgrade_test_scripts/run_gaia.sh

./contrib/scripts/upgrade_test_scripts/run_upgrade_commands.sh 15

./contrib/scripts/upgrade_test_scripts/test_upgrade.sh 20 5 16 localhost

gaiad q wasm params

TODO:

Fix Upgrade CI (which works locally)
Changelog

Reecepbcups · 2024-04-09T23:25:00Z

app/upgrades/v16/upgrades.go

+		wasmParams.CodeUploadAccess = wasmtypes.AllowNobody
+		// TODO(reece): only allow specific addresses to instantiate contracts or anyone with AccessTypeEverybody?
+		wasmParams.InstantiateDefaultPermission = wasmtypes.AccessTypeAnyOfAddresses


Need input on the team for if this. Should it be

InstantiateDefaultPermission = AccessTypeAnyOfAddresses (whitelisted wallets can instantiate new contracts as much as they want off of approve code ids from gov)

or InstantiateDefaultPermission = AccessTypeNobody (only gov only can create contracts off previously gov approved code)

To me AccessTypeAnyOfAddresses makes sense.

We want the governance to handle both code upload and instantiation.

IIUC, to use permissiond wasm we would need to use these settings:

wasmParams := wasmtypes.Params{ CodeUploadAccess: wasmtypes.AllowNobody, InstantiateDefaultPermission: wasmtypes.AllowNobody, }

I don't think that code upload is followed by an instantiation operation by default. But, that can be can be achieved through a gov prop that has 2 Txs to execute: [MsgStoreCode, MsgInstantiateContract]. This way, the uploaded contracts would immediately get instantiated.

We can use MsgStoreAndInstantiateContract to store and instantiate a contract via gov proposal.

Do you have any comments on this @Reecepbcups ?

This makes total sense yes, wasmtypes.AllowNobody is the desired param for both

MsgStoreAndInstantiateContract looks like it will allow the uploader (gov) to override the AccessConfig though for instantiates. InstantiateContractProposal does not have this.

I would assume this overrides the defaults since gov approved, which is a feature but actually a bug in our case for expected behavior. i.e. need to ante block a proposal if MsgStoreAndInstantiateContract.instantiate_permission is set

I think I'm getting it, thanks!

We will address those concerns before testnet and write new docs before cosmwasm lands on the hub mainnet.

app/upgrades/v16/upgrades.go

Reecepbcups · 2024-04-09T23:54:51Z

Upgrade works locally with versions but not here, odd.

webmaster128

Great stuff 🎉 I'm sure you know the Go integration part better than myself

.goreleaser.yml

webmaster128 · 2024-04-10T15:57:00Z

.goreleaser.yml

@@ -20,10 +20,8 @@ builds:
    goos:
      - darwin
      - linux
-      - windows


On Windows we can still build a client binary (through some build flags). However, the contract execution on Windows is not supported.

I'm not sure if goreleaser lets you specify the GOOS=windows GOARCH=amd64 go build $(BUILD_FLAGS) -o build/gaiad.exe ./cmd/gaiad for just 1 type of arch. Will have to look more into

I can take a look at this but I think you're right about the env vars.

Dockerfile

app/keepers/keepers.go

e2e.Dockerfile

Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>

Reecepbcups · 2024-04-10T17:41:57Z

contrib/single-node.sh

-sed -i '' 's/timeout_commit = "5s"/timeout_commit = "1s"/g' ~/.gaia/config/config.toml
-sed -i '' 's/timeout_propose = "3s"/timeout_propose = "1s"/g' ~/.gaia/config/config.toml
-sed -i '' 's/index_all_keys = false/index_all_keys = true/g' ~/.gaia/config/config.toml
+# sed -i '' 's#"tcp://127.0.0.1:26657"#"tcp://0.0.0.0:26657"#g' ~/.gaia/config/config.toml


These scripts probably need to be redone tbh. Happy to do if the team would like. Maybe another PR

ref what I use: https://github.com/CosmosContracts/juno/blob/main/scripts/test_node.sh

We have this in the backlob but we haven't started refactoring yet: #2950

We can add refactoring this script to that issue and do them all in a different PR.

MSalopek · 2024-04-11T17:21:11Z

@Reecepbcups
Hey, thanks for the your contribution! Clearly, there was quite a lot of work that went into this and we appreciate the effort!

I'd like to help pass all the checks (upgrade tests, e2e etc.) if you don't mind me adding to the PR?

As for merging this, the v16 release is already feature frozen and will be cut tomorrow morning (European time) as we have already prepared all the testing pipelines and made plans for the testnet upgrades. It's a pretty beefy release adding IBC features voted in by governance.

I think it should be pretty safe to merge this into main once we finalize the v16 release branch.

I'm really excited about this 🚀

Reecepbcups · 2024-04-11T18:53:40Z

@MSalopek Thanks and Sounds good on the v16 front. Yes, Maintainer edits are enabled.

github-actions · 2024-05-27T00:13:59Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Reecepbcups · 2024-05-27T03:16:50Z

I’ll pull in main Tuesday in prep for v18*

Conflicts resolved. Upgrade moved to gaia/v18

MSalopek · 2024-05-27T10:33:36Z

I’ll pull in main Tuesday in prep for v17

I already merged main into the branch (maintainer edits are enabled on the wasm-integration branch). I'm fixing tests.

v17 is already cut and the propsal is in voting (it has partial set security features enabled with some other goodies).
This brings a major change for the ICS protocol and all consumer chains so it was made into its own release.

v18 is next with cosmwasm, ibc-go v7.5.0 and some other upgrades. The PR will be merged as soon as all tests are passing and we provide a definite answer regarding this discussion: #3051 (comment).

The relatively fast upgrade cadence enables us to push out more features in distinct releases so we offset some risks around the upgrade.

MSalopek · 2024-05-27T17:01:30Z

e2e.Dockerfile

-ENV PACKAGES curl make git libc-dev bash gcc linux-headers eudev-dev python3
-RUN apk add --no-cache $PACKAGES
-RUN CGO_ENABLED=0 make install
+RUN LEDGER_ENABLED=false LINK_STATICALLY=true BUILD_TAGS=muslc make build


Had issues with this in e2e.

CGO needs to be enabled (don't know why).
I've also had to add RUN apk add --no-cache build-base in the runner container to make CGO available.

It seems that we cannot run the tests without CGO enabled.

I'm not sure what the implications of this are. While checking other projects, they all seem to be running with CGO enabled (or at least they don't explicitly disable it using CGO_ENABLED=0.

This repo contains both Rust and Go code. The Rust code is compiled into a library (shared .dll/.dylib/.so or static .a) to be linked via cgo and wrapped with a pleasant Go API

CGO is a requirement for CW yes https://github.com/CosmWasm/wasmvm

MSalopek

Thanks again for the PR!

All tests were cleaned up, the upgrade is passing.

There's a bit of work to do later.
We still need to check the goreleaser settings, update Dockerfile and make better upgrade tests.

The build got a bit complicated given the libwasmvm dep that can be either statically or dynamically linked. upgrade-test is using a dynamic linking approach while dockerized build uses static linking.

We will need to expand the build docs to show how to build with cosmwasm in mind.

[Docs]: update build and run docs for CosmWasm #3119

Reecepbcups added 2 commits April 9, 2024 18:03

integrate wasmd into gaia

44a6253

lint

01cdf43

Reecepbcups changed the title ~~feat!: integrate wasmd into gaia~~ feat!: integrate wasmd Apr 9, 2024

Reecepbcups changed the title ~~feat!: integrate wasmd~~ feat!: integrate cosmwasm Apr 9, 2024

Reecepbcups added 2 commits April 9, 2024 18:21

upload contract script example

f4ae1bc

add to upgrade handler

9c0fc2b

Reecepbcups commented Apr 9, 2024

View reviewed changes

Reecepbcups added 4 commits April 9, 2024 18:25

lint

3419477

rm: windows & arm64

2a34e25

docker libwasmvm_muslc wasmvm

94b5eda

actually set wasmd params in upgrade

a21f243

github-advanced-security bot found potential problems Apr 9, 2024

View reviewed changes

app/upgrades/v16/upgrades.go Fixed Show resolved Hide resolved

app/upgrades/v16/upgrades.go Fixed Show resolved Hide resolved

Reecepbcups marked this pull request as ready for review April 10, 2024 00:00

Reecepbcups requested review from alexanderbez, zmanian, crodriguezvega, jackzampolin and a team as code owners April 10, 2024 00:00

add sleeps

23cf3d3

webmaster128 reviewed Apr 10, 2024

View reviewed changes

Reecepbcups and others added 3 commits April 10, 2024 12:05

Dockerfile use alpine3.18

d89e4f2

Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>

arm64, WASMVM_VERSION, LINK_STATICALLY, AllCapabilities()

e905805

security: sha256sum wasmvm libwasmvm

0f5ebcd

Reecepbcups commented Apr 10, 2024

View reviewed changes

github-actions bot added the stale label May 27, 2024

stale bot removed the stale label May 27, 2024

Merge remote-tracking branch 'gaia-main/main' into wasmd-integration

99d6980

Conflicts resolved. Upgrade moved to gaia/v18

MSalopek added 2 commits May 27, 2024 12:40

appease linter

f313ae5

tests: use CGO, use correct libwasm; add CGO to runner img

677de89

MSalopek reviewed May 27, 2024

View reviewed changes

MSalopek added 7 commits May 28, 2024 13:04

tests: enable CGO in upgrade tests

ffc9ba9

tests: bump hermes version

837357f

tests: print output for upgrate test

d72962e

tests: print output for upgrate test

2c79728

attempt building in upgrade container

8fe0707

attempt building in upgrade container

9c670aa

tests: attempt building in upgrade container

2a3d1b9

mergify bot mentioned this pull request May 29, 2024

[debug] upgrade #3118

Closed

MSalopek added 3 commits May 29, 2024 14:16

tests: correctly download libwasmvm DLLs

d7fe6e9

chore: cleanup workflow file

c5711da

Merge branch 'main' into wasmd-integration

b90e4ac

MSalopek approved these changes May 29, 2024

View reviewed changes

tests: increase hermes gas multiplier

7e86862

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat!: integrate cosmwasm #3051

feat!: integrate cosmwasm #3051

Reecepbcups commented Apr 9, 2024 •

edited

Reecepbcups Apr 9, 2024 •

edited

MSalopek May 27, 2024 •

edited

Reecepbcups May 28, 2024 •

edited

MSalopek May 29, 2024

Reecepbcups commented Apr 9, 2024 •

edited

webmaster128 left a comment

webmaster128 Apr 10, 2024

Reecepbcups Apr 10, 2024

MSalopek Apr 11, 2024

Reecepbcups Apr 10, 2024

MSalopek Apr 11, 2024

MSalopek commented Apr 11, 2024

Reecepbcups commented Apr 11, 2024

github-actions bot commented May 27, 2024

Reecepbcups commented May 27, 2024 •

edited

MSalopek commented May 27, 2024

MSalopek May 27, 2024 •

edited

Reecepbcups May 28, 2024

MSalopek left a comment •

edited

@@ @@ -20,10 +20,8 @@ builds: @@
                   goos:
                     - darwin
                     - linux
-                    - windows

feat!: integrate cosmwasm #3051

Are you sure you want to change the base?

feat!: integrate cosmwasm #3051

Conversation

Reecepbcups commented Apr 9, 2024 • edited

Test Local node Script

Upload Wasm Contract

Local Upgrade

TODO:

Reecepbcups Apr 9, 2024 • edited

Choose a reason for hiding this comment

MSalopek May 27, 2024 • edited

Choose a reason for hiding this comment

Reecepbcups May 28, 2024 • edited

Choose a reason for hiding this comment

MSalopek May 29, 2024

Choose a reason for hiding this comment

Reecepbcups commented Apr 9, 2024 • edited

webmaster128 left a comment

Choose a reason for hiding this comment

webmaster128 Apr 10, 2024

Choose a reason for hiding this comment

Reecepbcups Apr 10, 2024

Choose a reason for hiding this comment

MSalopek Apr 11, 2024

Choose a reason for hiding this comment

Reecepbcups Apr 10, 2024

Choose a reason for hiding this comment

MSalopek Apr 11, 2024

Choose a reason for hiding this comment

MSalopek commented Apr 11, 2024

Reecepbcups commented Apr 11, 2024

github-actions bot commented May 27, 2024

Reecepbcups commented May 27, 2024 • edited

MSalopek commented May 27, 2024

MSalopek May 27, 2024 • edited

Choose a reason for hiding this comment

Reecepbcups May 28, 2024

Choose a reason for hiding this comment

MSalopek left a comment • edited

Choose a reason for hiding this comment

Reecepbcups commented Apr 9, 2024 •

edited

Reecepbcups Apr 9, 2024 •

edited

MSalopek May 27, 2024 •

edited

Reecepbcups May 28, 2024 •

edited

Reecepbcups commented Apr 9, 2024 •

edited

Reecepbcups commented May 27, 2024 •

edited

MSalopek May 27, 2024 •

edited

MSalopek left a comment •

edited