Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Introduce skip block sdk and fee market module #3028

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

stana-miric
Copy link
Contributor

@stana-miric stana-miric commented Mar 27, 2024

Description

This PR includes:

  1. Inregration of blocksdk
  2. Integration of feemarket module
  3. Removal of globalfee module from the app

Currently, the targeted feemarket code is github.com/MSalopek/feemarket v0.0.0-20240402122625-ab432d7d2a1c that contains adaptation for base fee as decimal value.
Also, some e2e tests are still failing, but this will be fixed once we decide how to deal with the fees(burn it or not based on the implementation here)
When all the above mentioned feemarket related fixes are merged, including fixing FeeMarketCheckDecorator to handle the case when gas is 0 (protection against devide by 0 in getTxPriority), then gaia should reference that feemarket code with all the fixes.

Note: before this PR is marked as ready, we need to decide what are wanted values for feemarket upgrade params MinBaseFee, TargetBlockUtilization and MaxBlockUtilization (marked as todo in app/upgrades/v16/upgrades.go)


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Added ! to the type prefix if API, client, or state breaking change (i.e., requires minor or major version bump)
  • Targeted the correct branch (see PR Targeting)
  • Provided a link to the relevant issue or specification
  • Followed the guidelines for building SDK modules
  • Included the necessary unit and integration tests
  • Added a changelog entry in .changelog (for details, see contributing guidelines)
  • Included comments for documenting Go code
  • Updated the relevant documentation or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage


params.Enabled = true
params.FeeDenom = "uatom"
// TODO check and set param values:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

before this PR is marked as ready, we need to decide what are wanted values for feemarket upgrade params

stana-miric and others added 10 commits May 24, 2024 10:35
Co-authored-by: Dusan Maksimovic <dusan.maksimovic@ethernal.tech>
Co-authored-by: Dusan Maksimovic <dusan.maksimovic@ethernal.tech>
Co-authored-by: Dusan Maksimovic <dusan.maksimovic@ethernal.tech>
Co-authored-by: Dusan Maksimovic <dusan.maksimovic@ethernal.tech>
Co-authored-by: Stana Miric <stana.miric@ethernal.tech>
Co-authored-by: Dusan Maksimovic <dusan.maksimovic@ethernal.tech>
Co-authored-by: Dusan Maksimovic <dusan.maksimovic@ethernal.tech>
Co-authored-by: Dusan Maksimovic <dusan.maksimovic@ethernal.tech>
tests/integration/test_utils.go Dismissed Show resolved Hide resolved
tests/integration/test_utils.go Dismissed Show resolved Hide resolved
Co-authored-by: Stana Miric <stana.miric@ethernal.tech>
dusan-maksimovic and others added 2 commits May 27, 2024 15:54
Co-authored-by: Stana Miric <stana.miric@ethernal.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants