-
Notifications
You must be signed in to change notification settings - Fork 659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Introduce skip block sdk and fee market module #3028
Draft
stana-miric
wants to merge
13
commits into
main
Choose a base branch
from
blocksdk-fee-market
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,061
−1,099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSalopek
reviewed
Mar 27, 2024
stana-miric
commented
Apr 5, 2024
app/upgrades/v16/upgrades.go
Outdated
|
||
params.Enabled = true | ||
params.FeeDenom = "uatom" | ||
// TODO check and set param values: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
before this PR is marked as ready, we need to decide what are wanted values for feemarket upgrade params
Co-authored-by: Dusan Maksimovic <dusan.maksimovic@ethernal.tech>
Co-authored-by: Dusan Maksimovic <dusan.maksimovic@ethernal.tech>
Co-authored-by: Dusan Maksimovic <dusan.maksimovic@ethernal.tech>
Co-authored-by: Dusan Maksimovic <dusan.maksimovic@ethernal.tech>
Co-authored-by: Stana Miric <stana.miric@ethernal.tech>
Co-authored-by: Dusan Maksimovic <dusan.maksimovic@ethernal.tech>
Co-authored-by: Dusan Maksimovic <dusan.maksimovic@ethernal.tech>
Co-authored-by: Dusan Maksimovic <dusan.maksimovic@ethernal.tech>
dusan-maksimovic
force-pushed
the
blocksdk-fee-market
branch
from
May 27, 2024 11:50
3524455
to
9052464
Compare
dusan-maksimovic
force-pushed
the
blocksdk-fee-market
branch
from
May 27, 2024 12:51
9052464
to
b0a7667
Compare
Co-authored-by: Stana Miric <stana.miric@ethernal.tech>
dusan-maksimovic
force-pushed
the
blocksdk-fee-market
branch
from
May 27, 2024 13:36
b0a7667
to
89d57b3
Compare
Co-authored-by: Stana Miric <stana.miric@ethernal.tech>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes:
Currently, the targeted feemarket code is github.com/MSalopek/feemarket v0.0.0-20240402122625-ab432d7d2a1c that contains adaptation for base fee as decimal value.
Also, some e2e tests are still failing, but this will be fixed once we decide how to deal with the fees(burn it or not based on the implementation here)
When all the above mentioned feemarket related fixes are merged, including fixing FeeMarketCheckDecorator to handle the case when gas is 0 (protection against devide by 0 in getTxPriority), then gaia should reference that feemarket code with all the fixes.
Note: before this PR is marked as ready, we need to decide what are wanted values for feemarket upgrade params MinBaseFee, TargetBlockUtilization and MaxBlockUtilization (marked as todo in app/upgrades/v16/upgrades.go)
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API, client, or state breaking change (i.e., requires minor or major version bump).changelog
(for details, see contributing guidelines)Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change