-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: adds ohmyzsh plugin for gaiad #2858
chore: adds ohmyzsh plugin for gaiad #2858
Conversation
shell_completion/README.md
Outdated
@@ -0,0 +1,9 @@ | |||
# gaiad |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please move shell_completion
folder to ./contrib
folder of the gaia repo?
hey @MSalopek , any other changes required to merge this in? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @MSalopek , any other changes required to merge this in?
-
I don't see any
provider
commands listed in the completions file. Is that by design? -
Instructions on how to update the completions when the CLI changes should be provided.
-
I'm assuming the completions were generated? If so, can you provide the generation script?
created an action that builds and gerated the completion script for ohmyzsh plugin using the inbuilt cobra engine updated makefile so as to make it easier to interact with this action and generate the script
the script is auto-generated thus did not modify it so as to ensure reproducibility.
Have added a command in the MAKEFILE have also added a github action that runs on main and release branches so as to automate the process of the script creation. Your input on the same would be appreciated. |
.github/workflows/gen-completion.yml
Outdated
name: Generate ohmyzsh completion | ||
on: | ||
push: | ||
branches: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this then update the script for every push to main/release branches? My preference would be to do this manually (in the release checklist) or add it to the release task. Do you have a preference @MSalopek ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mmulji-ic have removed the automation script so as to allow for manual generation and distribution of the script rather than relying on automation.
@@ -309,3 +309,12 @@ proto-swagger-gen: | |||
@sh ./proto/scripts/protoc-swagger-gen.sh | |||
|
|||
.PHONY: proto-gen proto-doc proto-swagger-gen | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Running this target, produced a different contrib/shell_completion/_gaiad
file. Should update that file for this PR. Want to see if its due to system differences or a build off an older commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @mmulji-ic have tested this on my local machine and it is indeed updating the _gaiad file rather than creating a new one.
Is there any specific step you are following? so that i can reproduce this on my machine?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @tokamak-git the file generated on my system was different, was wondering if this was system related or just an older generation of the completions file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So it will update depending on what features the cli implements.
So it should have a different output as compared as I'm sure the branch your on has different cli features from the one generated on the pr.
Hey folks. are there any changes you would recommend to this? |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Description
Closes: #1331
#1331
adds ohmyzsh completion script with instructions for gaiad
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...