-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/distribution: In-Process Testing & CLI Refactor #6652
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6652 +/- ##
==========================================
+ Coverage 57.67% 58.47% +0.79%
==========================================
Files 502 502
Lines 30040 30088 +48
==========================================
+ Hits 17327 17594 +267
+ Misses 11463 11205 -258
- Partials 1250 1289 +39 |
…mos-sdk into bez/6423-in-process-cli-distr
…mos-sdk into bez/6423-in-process-cli-distr
@alexanderbez Are you planning to touch on cosmos-sdk/x/distribution/client/cli/tx.go Line 235 in 8670a10
Don't want to step on your toes wrt #6664 |
@amaurymartiny yes, absolutely. Thanks for checking. All commands will have arguments removed in favor of getting everything they need from the command's context and flags. I should be done this PR in a few hours, so you should be able to resume your work shortly. In fact, I've just finished the query commands. I'm moving onto tx commands. |
@amaurymartiny I've updated the files if you need a reference for your PR. |
Description
ref: #6423
ref: #6571
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes