Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/distribution: In-Process Testing & CLI Refactor #6652

Merged
merged 30 commits into from
Jul 10, 2020

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Jul 8, 2020

Description

ref: #6423
ref: #6571


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@alexanderbez alexanderbez added C:CLI C:x/distribution distribution module related Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. A:automerge Automatically merge PR once all prerequisites pass. labels Jul 8, 2020
@aaronc aaronc mentioned this pull request Jul 8, 2020
19 tasks
@codecov
Copy link

codecov bot commented Jul 8, 2020

Codecov Report

Merging #6652 into master will increase coverage by 0.79%.
The diff coverage is 46.80%.

@@            Coverage Diff             @@
##           master    #6652      +/-   ##
==========================================
+ Coverage   57.67%   58.47%   +0.79%     
==========================================
  Files         502      502              
  Lines       30040    30088      +48     
==========================================
+ Hits        17327    17594     +267     
+ Misses      11463    11205     -258     
- Partials     1250     1289      +39     

@amaury1093
Copy link
Contributor

@alexanderbez Are you planning to touch on

func GetCmdSubmitProposal(clientCtx client.Context) *cobra.Command {
in this PR?

Don't want to step on your toes wrt #6664

@alexanderbez
Copy link
Contributor Author

@alexanderbez Are you planning to touch on

func GetCmdSubmitProposal(clientCtx client.Context) *cobra.Command {

in this PR?
Don't want to step on your toes wrt #6664

@amaurymartiny yes, absolutely. Thanks for checking. All commands will have arguments removed in favor of getting everything they need from the command's context and flags. I should be done this PR in a few hours, so you should be able to resume your work shortly. In fact, I've just finished the query commands. I'm moving onto tx commands.

@alexanderbez
Copy link
Contributor Author

@amaurymartiny I've updated the files if you need a reference for your PR.

@clevinson clevinson added this to Untriaged in Cosmos SDK Project Board via automation Jul 10, 2020
@clevinson clevinson added this to the v0.40 [Stargate] milestone Jul 10, 2020
@clevinson clevinson moved this from Untriaged to In progress in Cosmos SDK Project Board Jul 10, 2020
Cosmos SDK Project Board automation moved this from In progress to Review In Progress Jul 10, 2020
@alexanderbez alexanderbez merged commit 400c3cb into master Jul 10, 2020
Cosmos SDK Project Board automation moved this from Review In Progress to Done Jul 10, 2020
@alexanderbez alexanderbez deleted the bez/6423-in-process-cli-distr branch July 10, 2020 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:CLI C:x/distribution distribution module related Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.
Projects
No open projects
Cosmos SDK Project Board
  
Archived (2020-08-10)
Development

Successfully merging this pull request may close these issues.

None yet

4 participants