Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keys: CLI Remove Viper #6613

Merged
merged 16 commits into from
Jul 6, 2020
Merged

keys: CLI Remove Viper #6613

merged 16 commits into from
Jul 6, 2020

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Jul 6, 2020

Description

ref: #6571


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@alexanderbez alexanderbez added C:CLI C:Keys Keybase, KMS and HSMs Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. A:automerge Automatically merge PR once all prerequisites pass. labels Jul 6, 2020
@alexanderbez alexanderbez mentioned this pull request Jul 6, 2020
27 tasks
@alexanderbez alexanderbez changed the title keys: CLI Remova Viper keys: CLI Remove Viper Jul 6, 2020
@codecov
Copy link

codecov bot commented Jul 6, 2020

Codecov Report

Merging #6613 into master will increase coverage by 1.93%.
The diff coverage is 67.01%.

@@            Coverage Diff             @@
##           master    #6613      +/-   ##
==========================================
+ Coverage   55.60%   57.53%   +1.93%     
==========================================
  Files         457      493      +36     
  Lines       27440    29558    +2118     
==========================================
+ Hits        15257    17006    +1749     
- Misses      11083    11339     +256     
- Partials     1100     1213     +113     

@alexanderbez alexanderbez marked this pull request as ready for review July 6, 2020 17:36
@alexanderbez alexanderbez marked this pull request as draft July 6, 2020 17:36
@alexanderbez alexanderbez marked this pull request as ready for review July 6, 2020 18:55
@mergify mergify bot merged commit de7885a into master Jul 6, 2020
@mergify mergify bot deleted the bez/6571-viper-removal-cli-keys branch July 6, 2020 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:CLI C:Keys Keybase, KMS and HSMs Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants