-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: move logger to core #20388
chore: move logger to core #20388
Conversation
Important Review SkippedMore than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review. 34 files out of 91 files are above the max files limit of 50. Please upgrade to Pro plan to get higher limits. You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Concept ACK, but that blocks the release of a new log version until core is tagged.
I think we implemented everything we wanted there, so this package can be considered as "done", but just noting.
Can we add a changelog in core and log as well about this?
package log | ||
|
||
// Logger is the Cosmos SDK logger interface. | ||
// It maintains as much backward compatibility with the CometBFT logger as possible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would mention that cosmossdk.io/log is the implementation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@@ -27,39 +29,15 @@ func init() { | |||
} | |||
|
|||
// ModuleKey defines a module logging key. | |||
const ModuleKey = "module" | |||
const ModuleKey = corelog.ModuleKey |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Imo there is no need to have logger import core, feels like adding an edge to the dependency graph for no real reason.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Logger needs to import core, due to With(...) Logger
. Otherwise, it doesn't fulfill the interface.
Description
this pr proposes moving the logger interface to core to avoid modules depending on logger. Instead the logger dep should be a top level dep
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
in the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...