Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove txs from mempool when antehandler fails in recheck (backport #20144) #20251

Merged
merged 1 commit into from
May 2, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented May 2, 2024

Description

this pr removes txs from the mempool when the antehandler fails and the mode is in recheck


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

  • New Features
    • Enhanced error handling for transaction processing, ensuring smoother performance and reliability.
  • Tests
    • Updated test assertions to align with new transaction handling behaviors.
  • Bug Fixes
    • Improved handling of failed ante handler during transaction recheck.

This is an automatic backport of pull request #20144 done by [Mergify](https://mergify.com).

Co-authored-by: Facundo <facundomedica@gmail.com>
(cherry picked from commit 599ae55)
@mergify mergify bot requested a review from a team as a code owner May 2, 2024 14:53
Copy link
Contributor

github-actions bot commented May 2, 2024

@mergify[bot] your pull request is missing a changelog!

@tac0turtle tac0turtle merged commit 8ffc807 into release/v0.50.x May 2, 2024
46 of 47 checks passed
@tac0turtle tac0turtle deleted the mergify/bp/release/v0.50.x/pr-20144 branch May 2, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant