Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(x/staking-upgrade): fix proto broken links #20202

Closed
wants to merge 4 commits into from
+28 −28
Closed

docs(x/staking-upgrade): fix proto broken links #20202

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4138924
docs: fix proto link in x/upgrade
kien6034 Apr 28, 2024
d80106a
docs: fix proto link in x/staking
kien6034 Apr 28, 2024
c2f8c49
chore: add commit ref instead of main
kien6034 May 2, 2024
e95abdd
Merge branch 'main' into fix/module-broken-links
kien6034 May 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions x/upgrade/README.md
View file
Open in desktop
Copy link
Contributor Author

@kien6034 kien6034 May 2, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@julienrbrt sorry for the late update, i took some days off for our holiday. Should we do this instead?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets use a tag, there isnt much benefit to a commit here

Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ the `Plan`, which targets a specific `Handler`, is persisted and scheduled. The
upgrade can be delayed or hastened by updating the `Plan.Height` in a new proposal.

```protobuf reference
https://github.com/cosmos/cosmos-sdk/blob/main/x/upgrade/proto/cosmos/upgrade/v1beta1/tx.proto#L29-L41
https://github.com/cosmos/cosmos-sdk/blob/2e39dcb5dd8ffd19cf00d9017a7391e324777d83/x/upgrade/proto/cosmos/upgrade/v1beta1/tx.proto#L29-L41
```

#### Cancelling Upgrade Proposals
Expand All @@ -115,7 +115,7 @@ Of course this requires that the upgrade was known to be a bad idea well before
upgrade itself, to allow time for a vote.

```protobuf reference
https://github.com/cosmos/cosmos-sdk/blob/main/x/upgrade/proto/cosmos/upgrade/v1beta1/tx.proto#L48-L56
https://github.com/cosmos/cosmos-sdk/blob/2e39dcb5dd8ffd19cf00d9017a7391e324777d83/x/upgrade/proto/cosmos/upgrade/v1beta1/tx.proto#L48-L56
```

If such a possibility is desired, the upgrade height is to be
Expand Down