Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] test: staking query not module query safe #20147

Conversation

crodriguezvega
Copy link

@crodriguezvega crodriguezvega commented Apr 22, 2024

Description

Opening this PR to show an issue we are trying to debug in ibc-go.

We are back porting ICA queries to release/v7.5.x and If we run our tests using go 1.19, then a test that checks that the staking queries are module safe queries fails. However, if we run the tests with go 1.22, then it passes... You can see the failure in the test of this PR here.

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

@facundomedica
Copy link
Member

facundomedica commented Apr 23, 2024

1.19 and 1.20 fail, 1.21 and 1.22 passes. Also allowList has a length of 7 vs 32 when working correctly.

EDIT: Importing the package works _ "cosmossdk.io/api/cosmos/staking/v1beta1", now we have to find why it works differently

@facundomedica
Copy link
Member

So far it seems that this is related to a change in how Go initializes packages: https://tip.golang.org/doc/go1.21

I can't find precisions on the previous behavior as it's "unspecified".

@kocubinski kocubinski self-assigned this Apr 25, 2024
@tac0turtle
Copy link
Member

closing this for now, we should open an issue to track it

@tac0turtle tac0turtle closed this Apr 30, 2024
@tac0turtle tac0turtle deleted the carlos/staking-query-not-module-query-safe branch April 30, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🥳 Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants