Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(x/accounts): Add schema caching feature and corresponding test case #20055

Merged
merged 55 commits into from May 17, 2024
Merged
Show file tree
Hide file tree
Changes from 48 commits
Commits
Show all changes
55 commits
Select commit Hold shift + click to select a range
0070d42
feat(x/accounts): Add schema caching feature and corresponding test case
meetrick Apr 16, 2024
389c2f1
fix(x/accounts): Avoid copying queryServer in its methods
meetrick Apr 16, 2024
4a20c00
Initialize mu as a pointer
meetrick Apr 16, 2024
9169303
Merge branch 'main' into 20240416_2
meetrick Apr 17, 2024
33fc9f8
Merge branch 'main' into 20240416_2
meetrick Apr 17, 2024
fcb45ce
chore(accounts): Ensure queryServer methods use pointer receivers
meetrick Apr 22, 2024
718cd59
Merge branch 'main' into 20240416_2
meetrick Apr 22, 2024
5ff10e3
chore: remove grpc-web (#20140)
tac0turtle Apr 23, 2024
8ea9ff5
docs: add authz reference info in the circuit antehandler (#20146)
Reecepbcups Apr 23, 2024
1cbe3f3
build(deps): Bump github.com/prometheus/common from 0.52.2 to 0.53.0 …
dependabot[bot] Apr 23, 2024
0b4e783
chore: reduce codeql time (#20158)
tac0turtle Apr 23, 2024
30f9375
fix(client/v2): close json file (#20120)
testwill Apr 23, 2024
d8ec18f
fix: Fix data race test coverage. (#20156)
tnv1 Apr 23, 2024
793c594
build(deps): Bump cosmossdk.io/x/tx from 0.13.2 to 0.13.3 (#20149)
dependabot[bot] Apr 23, 2024
2d90252
fix(simapp): store key override accounts (#20163)
julienrbrt Apr 24, 2024
2d614a1
refactor(lockup account): Add tests for lockup account (#19772)
sontrinh16 Apr 24, 2024
ff88c22
build(deps): Bump bufbuild/buf-setup-action from 1.30.1 to 1.31.0 (#2…
dependabot[bot] Apr 24, 2024
21a2269
build(deps): Bump amannn/action-semantic-pull-request from 5.4.0 to 5…
dependabot[bot] Apr 24, 2024
c604ffd
docs(x/authz): Update Staking Module Broken Link (#20157)
Erlangshen219 Apr 24, 2024
fd02ae0
chore: fix function names (#20170)
cuithon Apr 24, 2024
f58c610
chore: fix some quoting (#20166)
ChengenH Apr 24, 2024
5b61fce
chore: fix malformed struct tag (#20142)
ipangpang Apr 24, 2024
fc9cbe4
fix(docs): fix broken links (#20169)
goofylfg Apr 24, 2024
062433f
chore: remove unused testing framework (#20175)
tac0turtle Apr 24, 2024
c7ad722
tests(sims): Use temp dir for sims (#20143)
alpe Apr 24, 2024
964c562
build(deps): Bump github.com/cosmos/cosmos-sdk from 0.50.6-0.20240403…
dependabot[bot] Apr 25, 2024
e868c06
chore: remove repetitive words (#20180)
goofylfg Apr 25, 2024
8767a78
build(deps): Bump amannn/action-semantic-pull-request from 5.5.0 to 5…
dependabot[bot] Apr 25, 2024
1a203d1
fix(testsuite/sims): set all signatures (#20151)
leonz789 Apr 25, 2024
024003f
refactor: migrate to query Consensus Params (#19600)
tac0turtle Apr 25, 2024
12c7dee
chore: fix spelling errors (#20187)
github-prbot Apr 25, 2024
6a5ef16
feat(x/authz): Add `MsgRevokeAll` (#20161)
kien6034 Apr 26, 2024
41cd7b3
tests(types/tx): Add unit tests for types/tx (#20153)
EmilGeorgiev Apr 26, 2024
426c697
docs(x/auth/tx): fix typo in decodeMultisignatures function comment (…
meetrick Apr 26, 2024
12ab4ca
docs(x/authz): fix broken link (#20194)
hoanguyenkh Apr 26, 2024
ff0cbc7
build(deps): Bump cosmossdk.io/x/upgrade from 0.1.2-0.20240403102038-…
dependabot[bot] Apr 26, 2024
2449560
build(deps): Bump cosmossdk.io/store from 1.0.2 to 1.1.0 (#20191)
dependabot[bot] Apr 26, 2024
05c820a
chore: fix all typos (#20196)
hoangdv2429 Apr 26, 2024
422dc8a
refactor(proto): add denote version annotation (#20098)
minhngoc274 Apr 26, 2024
688163c
chore(docs/learn): fix broken links (#20193)
goofylfg Apr 26, 2024
8e929f7
test(store/snapshot): fix flaky test (#20078)
EmilGeorgiev Apr 26, 2024
a92ccce
docs(lockup): add documentation (#19898)
tac0turtle Apr 26, 2024
b79de2f
refactor(x/accounts): add sender assertions to SendModuleMessageUntyp…
sontrinh16 Apr 26, 2024
10fc2b8
refactor(baseapp): when the capacity is determined, avoid memory copy…
0x2d3c Apr 28, 2024
1ddeb8d
docs(x/circuit): fix broken link (#20201)
hoank101 Apr 28, 2024
fc07c2f
perf: Make recheck not re-run validate basic (#20208)
ValarDragon Apr 29, 2024
b1c0693
refactor(x/accounts/defaults/lockup): Clean up some logic (#20037)
sontrinh16 Apr 29, 2024
fafc385
Removed mutex in each function
meetrick Apr 29, 2024
90e1bc8
Merge branch 'main' into 20240416_2
meetrick Apr 29, 2024
e15cae8
Removed cache operation in Schema()
meetrick Apr 29, 2024
28f3431
Update x/accounts/query_server.go
meetrick Apr 29, 2024
ecb8d3f
Removoed SchemaCache field
meetrick May 14, 2024
b943f6f
Merge branch 'main' into 20240416_2
meetrick May 14, 2024
f6d2846
Removed unnecessary field from queryServer struct
meetrick May 14, 2024
848540c
Merge branch 'main' into 20240416_2
sontrinh16 May 17, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
4 changes: 4 additions & 0 deletions .github/workflows/codeql-analysis.yml
Expand Up @@ -11,6 +11,10 @@ on:
paths:
- "**.go"

concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
cancel-in-progress: true

jobs:
analyze:
name: Analyze
Expand Down
7 changes: 7 additions & 0 deletions .github/workflows/gosec.yml
@@ -1,6 +1,9 @@
name: Run Gosec
on:
pull_request:
branches:
- main
- release/**
paths:
- "**/*.go"
- "go.mod"
Expand All @@ -13,6 +16,10 @@ on:
- "go.mod"
- "go.sum"

concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
cancel-in-progress: true

jobs:
Gosec:
permissions:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/lint-pr.yml
Expand Up @@ -17,7 +17,7 @@ jobs:
statuses: write # for amannn/action-semantic-pull-request to mark status of analyzed PR
runs-on: ubuntu-latest
steps:
- uses: amannn/action-semantic-pull-request@v5.4.0
- uses: amannn/action-semantic-pull-request@v5.5.2
id: lint_pr_title
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/proto.yml
Expand Up @@ -15,7 +15,7 @@ jobs:
timeout-minutes: 5
steps:
- uses: actions/checkout@v4
- uses: bufbuild/buf-setup-action@v1.30.1
- uses: bufbuild/buf-setup-action@v1.31.0
- uses: bufbuild/buf-lint-action@v1
with:
input: "proto"
Expand All @@ -24,7 +24,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: bufbuild/buf-setup-action@v1.30.1
- uses: bufbuild/buf-setup-action@v1.31.0
- uses: bufbuild/buf-breaking-action@v1
with:
input: "proto"
Expand Down
96 changes: 0 additions & 96 deletions .github/workflows/starship-tests.yml

This file was deleted.

23 changes: 23 additions & 0 deletions .github/workflows/test.yml
Expand Up @@ -700,6 +700,29 @@ jobs:
with:
projectBaseDir: x/accounts/

test-x-accounts-lockup:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/setup-go@v5
with:
go-version: "1.22"
check-latest: true
cache: true
cache-dependency-path: x/accounts/defaults/lockup/go.sum
- uses: technote-space/get-diff-action@v6.1.2
id: git_diff
with:
PATTERNS: |
x/accounts/defaults/lockup/**/*.go
x/accounts/defaults/lockup/go.mod
x/accounts/defaults/lockup/go.sum
- name: tests
if: env.GIT_DIFF
run: |
cd x/accounts/defaults/lockup
go test -mod=readonly -timeout 30m -coverprofile=coverage.out -covermode=atomic -tags='norace ledger test_ledger_mock' ./...

test-x-tx:
runs-on: ubuntu-latest
steps:
Expand Down
5 changes: 4 additions & 1 deletion CHANGELOG.md
Expand Up @@ -70,7 +70,7 @@ Every module contains its own CHANGELOG.md. Please refer to the module you are i
* (types) [#19512](https://github.com/cosmos/cosmos-sdk/pull/19512) The notion of basic manager does not exist anymore (and all related helpers).
* The module manager now can do everything that the basic manager was doing.
* `AppModuleBasic` has been deprecated for extension interfaces.
* Modules can now implement `appmodule.HasRegisterInterfaces`, `modue.HasGRPCGateway` and `module.HasAminoCodec` when relevant.
* Modules can now implement `appmodule.HasRegisterInterfaces`, `module.HasGRPCGateway` and `module.HasAminoCodec` when relevant.
* SDK modules now directly implement those extension interfaces on `AppModule` instead of `AppModuleBasic`.
* (client/keys) [#18950](https://github.com/cosmos/cosmos-sdk/pull/18950) Improve `<appd> keys add`, `<appd> keys import` and `<appd> keys rename` by checking name validation.
* (client/keys) [#18745](https://github.com/cosmos/cosmos-sdk/pull/18745) Improve `<appd> keys export` and `<appd> keys mnemonic` by adding --yes option to skip interactive confirmation.
Expand All @@ -93,6 +93,8 @@ Every module contains its own CHANGELOG.md. Please refer to the module you are i
* (x/auth) [#19651](https://github.com/cosmos/cosmos-sdk/pull/19651) Allow empty public keys in `GetSignBytesAdapter`.
* (x/genutil) [#19735](https://github.com/cosmos/cosmos-sdk/pull/19735) Update genesis api to match new `appmodule.HasGenesis` interface.
* (server) [#19966](https://github.com/cosmos/cosmos-sdk/pull/19966) Return BlockHeader by shallow copy in server Context.
* (proto) [#20098](https://github.com/cosmos/cosmos-sdk/pull/20098) Use cosmos_proto added_in annotation instead of // Since comments.
* (baseapp) [#20208](https://github.com/cosmos/cosmos-sdk/pull/20208) Skip running validateBasic for rechecking txs.

### Bug Fixes

Expand Down Expand Up @@ -174,6 +176,7 @@ Every module contains its own CHANGELOG.md. Please refer to the module you are i
* Additionally, to reflect this change, the module manager does not take a codec either.
* (runtime) [#19747](https://github.com/cosmos/cosmos-sdk/pull/19747) `runtime.ValidatorAddressCodec` and `runtime.ConsensusAddressCodec` have been moved to `core`.
* (baseapp) [#19993](https://github.com/cosmos/cosmos-sdk/pull/19993) Indicate pruning with error code "not found" rather than "invalid request".
* (server) [#20140](https://github.com/cosmos/cosmos-sdk/pull/20140) Remove embedded grpc-web proxy in favor of standalone grpc-web proxy. [Envoy Proxy](https://www.envoyproxy.io/docs/envoy/latest/start/start)

### Client Breaking Changes

Expand Down
6 changes: 3 additions & 3 deletions Makefile
Expand Up @@ -96,8 +96,8 @@ ifeq (debug,$(findstring debug,$(COSMOS_BUILD_OPTIONS)))
BUILD_FLAGS += -gcflags "all=-N -l"
endif

#? all: Run tools build lint test vulncheck
all: tools build lint test vulncheck
#? all: Run tools build
all: build

# The below include contains the tools and runsim targets.
include contrib/devtools/Makefile
Expand Down Expand Up @@ -487,4 +487,4 @@ localnet-debug: localnet-stop localnet-build-dlv localnet-build-nodes
help: Makefile
@echo " Choose a command run in "$(PROJECT_NAME)":"
@sed -n 's/^#?//p' $< | column -t -s ':' | sort | sed -e 's/^/ /'
.PHONY: help
.PHONY: help
4 changes: 4 additions & 0 deletions UPGRADING.md
Expand Up @@ -61,6 +61,10 @@ For non depinject users, simply call `RegisterLegacyAminoCodec` and `RegisterInt

Additionally, thanks to the genesis simplification, as explained in [the genesis interface update](#genesis-interface), the module manager `InitGenesis` and `ExportGenesis` methods do not require the codec anymore.

##### GRPC-WEB

Grpc-web embedded client has been removed from the server. If you would like to use grpc-web, you can use the [envoy proxy](https://www.envoyproxy.io/docs/envoy/latest/start/start).

##### AnteHandlers

The `GasConsumptionDecorator` and `IncreaseSequenceDecorator` have been merged with the SigVerificationDecorator, so you'll
Expand Down