Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump store to comet v1 #19991

Closed
wants to merge 2 commits into from
Closed

bump store to comet v1 #19991

wants to merge 2 commits into from

Conversation

tac0turtle
Copy link
Member

Description

to upgrade main sdk we need to bump store v1 to cometbft v1. This is breaking so we may need to issue a new v1.2. It will only be usable by main as well.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

@tac0turtle tac0turtle added the S:blocked Status: Blocked label Apr 9, 2024
@tac0turtle
Copy link
Member Author

closing this as I will fix it on main after storev1 Is brought up to main

@tac0turtle tac0turtle closed this May 3, 2024
@tac0turtle tac0turtle deleted the comet/1/store branch May 3, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:Store S:blocked Status: Blocked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant