Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix typo in 06-grpc_rest.md #19189

Closed

Conversation

taramakage
Copy link
Contributor

Description

Closes: #19174


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

@taramakage taramakage requested a review from a team as a code owner January 23, 2024 14:28
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thanks for this PR, however could you target main instead? We'll backport all the way down.

@taramakage
Copy link
Contributor Author

Hi! Thanks for this PR, however could you target main instead? We'll backport all the way down.

Yes no problem. I will close this PR and then fork the main branch to make corrections because the PR is based on the release/v0.47.x branch and would result in conflicts when targeting main.

@taramakage taramakage closed this Jan 23, 2024
@taramakage taramakage mentioned this pull request Jan 23, 2024
12 tasks
@taramakage taramakage deleted the fix-doc-typo-v0.47.x branch January 23, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants