feat(server/v2): Add upgradeblock #18931
Conversation
This pr adds preblock to server/v2. It adds it to stf since it will be a stateful call that could cause state updates
|
@tac0turtle your pull request is missing a changelog! |
| type UpgradeModule interface { | ||
| UpgradeBlocker() func(ctx context.Context) error | ||
| } |
There was a problem hiding this comment.
What is UpgradeBlocker? How does it relate to PreBlock?
There was a problem hiding this comment.
meant to replace preblocker as preblocker was a generalised implementation any module could use while we only want to expose this for upgrade, for now. We will refactor how upgrades work in the future
There was a problem hiding this comment.
I'm sorry, I'm confused. So we have PreBlocker and UpgradeBlocker now.
There was a problem hiding this comment.
preblocker was renamed to upgradeblocker
There was a problem hiding this comment.
Ok I see I was renamed/removed now, thanks! I think when I first reviewed this, they both existed, hence my confusion :)
tac0turtle
changed the title
| type UpgradeModule interface { | ||
| UpgradeBlocker() func(ctx context.Context) error | ||
| } |
There was a problem hiding this comment.
Ok I see I was renamed/removed now, thanks! I think when I first reviewed this, they both existed, hence my confusion :)
Co-authored-by: unknown unknown <unknown@unknown>
Description
This pr adds upgrade to server/v2, it replaces preblocks job. It adds it to stf since it will be a stateful call that could cause state updates
ref #18282
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...