Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert f235aae (part 2) #16697

Merged
merged 2 commits into from Jun 27, 2023
Merged

fix: revert f235aae (part 2) #16697

merged 2 commits into from Jun 27, 2023

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Jun 26, 2023

Description

When testing the server changes (ref #16698), I have noticed that grpcui and grpcurl were broken because of that update.
follow-up of #16534.
I think we should strive for compatibility and still revert f235aae as well for the SDK.

cc @tac0turtle as you were involved in the discussion in #16534


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt added the backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release label Jun 26, 2023
@julienrbrt julienrbrt requested a review from a team as a code owner June 26, 2023 16:58
@github-prbot github-prbot requested review from a team, kocubinski and likhita-809 and removed request for a team June 26, 2023 16:58
@tac0turtle
Copy link
Member

what is the error causing the issue?

@julienrbrt
Copy link
Member Author

what is the error causing the issue?

grpcurl still supports reflection v1beta1 only and grpcui as well (https://github.com/search?q=repo%3Afullstorydev%2Fgrpcui%20NewClient&type=code)

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense, need to add nolint or add the rule to golangci.yaml

@julienrbrt julienrbrt added this pull request to the merge queue Jun 27, 2023
Merged via the queue into main with commit a067ef6 Jun 27, 2023
47 of 48 checks passed
@julienrbrt julienrbrt deleted the julien/revert-f235aae-2 branch June 27, 2023 13:50
mergify bot pushed a commit that referenced this pull request Jun 27, 2023
(cherry picked from commit a067ef6)
julienrbrt added a commit that referenced this pull request Jun 27, 2023
Co-authored-by: Julien Robert <julien@rbrt.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants