refactor: update crypto/ledger to btcec/v2

[julienrbrt]

Description

ref: #13513 (comment)
kindly pinging @elias-orijtech

cd crypto/ledger
go test ./... -tags='ledger,test_ledger_mock'
ok      github.com/cosmos/cosmos-sdk/crypto/ledger      0.118s

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title
• added ! to the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• followed the guidelines for building modules
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• included comments for documenting Go code
• updated the relevant documentation or specification
• reviewed "Files changed" and left comments if necessary
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed ! in the type prefix if API or client breaking change
• confirmed all author checklist items have been addressed
• reviewed state machine logic
• reviewed API design and naming
• reviewed documentation is accurate
• reviewed tests and test coverage
• manually tested (if applicable)

[elias-orijtech]

Perhaps @odeke-em would like to take a quick look as well.

[ftheirs]

LGTM! 👍

[sonarcloud]

[Cosmos SDK] Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

93.8% Coverage
0.0% Duplication

[odeke-em]

Thank you for this change @julienrbrt, and thank you for the co-review and tag @elias-orijtech! I've added some suggestions, please take a look @julienrbrt and then I'll approve

[odeke-em]

Might seem paranoid, but I suggest that we add a length minimum check here

// Validating that we have a somewhat proper DER signature.
if n := len(sigDER); n < 4 {
    return nil, fmt.Errorf("invalid DER length: want >=4 got %d", n)
}
if g, w := sigDER[0], 0x30; g != w {
    return nil, fmt.Errorf("invalid DER: byte[0]=%x, want=%x", g, w)
}
if wantLen, gotLen := int(sigDER[1]), len(sigDER[3:]); gotLen != wantLen {
    return nil, fmt.Errorf("invalid DER len: got=%d, want=%d",
       gotLen, wantLen)
}

// Eliminate compiler Bounds checking.
_ = sigDER[9:]

[julienrbrt]

Seems a bit paranoid indeed, given that Serialize always returns this format.
https://go.dev/play/p/WuZKekW5s9x

[odeke-em]

Cool no biggie.

[tac0turtle]

utACK

[sonarcloud]

[Cosmos SDK - SimApp] Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information