Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(baseapp): fix snapshot interval bug #14049

Merged
merged 4 commits into from Nov 28, 2022
Merged

fix(baseapp): fix snapshot interval bug #14049

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d99b56f
fix(baseapp): fix snapshot interval bug
JeancarloBarrios Nov 28, 2022
0fdc9c2
changelog
JeancarloBarrios Nov 28, 2022
f53822b
Update CHANGELOG.md
JeancarloBarrios Nov 28, 2022
21a009d
remove unesessary variable
JeancarloBarrios Nov 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion baseapp/options.go
View file
Open in desktop
Expand Up @@ -216,7 +216,7 @@ func (app *BaseApp) SetSnapshot(snapshotStore *snapshots.Store, opts snapshottyp
if app.sealed {
panic("SetSnapshot() on sealed BaseApp")
}
if snapshotStore == nil || opts.Interval == snapshottypes.SnapshotIntervalOff {
if snapshotStore == nil {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we remove this, then SnapshotIntervalOff is never used anywhere. Maybe we can remove this const as well.

When opts.Interval is not set / 0, everything will be pruned.

cosmos-sdk/store/pruning/manager.go

Lines 138 to 143 in 04db139

// We consider this height to be pruned iff:
//
// - snapshotInterval is zero as that means that all heights should be pruned.
// - snapshotInterval % (height - KeepRecent) != 0 as that means the height is not
// a 'snapshot' height.
if m.snapshotInterval == 0 || pruneHeight%int64(m.snapshotInterval) != 0 {

app.snapshotManager = nil
return
}
Expand Down