Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(group)!: Fix group min execution period #13876

Merged
merged 12 commits into from Nov 16, 2022
Merged

fix(group)!: Fix group min execution period #13876

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
11c8e7a
fix: don't check MinExecutionPeriod in `Allow`
amaury1093 Nov 15, 2022
e747e84
Check MinExecutionPeriod on doExecuteMsgs
amaury1093 Nov 15, 2022
c9c0b01
Fix TestExec
amaury1093 Nov 15, 2022
6e0e7e8
Fix TestExec
amaury1093 Nov 15, 2022
36f381c
test exec pruned
amaury1093 Nov 15, 2022
e6ed07d
Fix submitproposal
amaury1093 Nov 15, 2022
130a0e4
Add changelog
amaury1093 Nov 15, 2022
83a91f8
typo
amaury1093 Nov 15, 2022
b747bf5
revert some changes
amaury1093 Nov 15, 2022
df0843d
add minExecutionPeriod
amaury1093 Nov 15, 2022
0d123fc
Merge branch 'main' of ssh://github.com/cosmos/cosmos-sdk into am/fix…
amaury1093 Nov 16, 2022
fcaaee5
Add docs and specs
amaury1093 Nov 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Expand Up @@ -114,6 +114,7 @@ Ref: https://keepachangelog.com/en/1.0.0/
* (x/gov) [#12771](https://github.com/cosmos/cosmos-sdk/pull/12771) Initial deposit requirement for proposals at submission time.
* (x/staking) [#12967](https://github.com/cosmos/cosmos-sdk/pull/12967) `unbond` now creates only one unbonding delegation entry when multiple unbondings exist at a single height (e.g. through multiple messages in a transaction).
* (x/auth/vesting) [#13502](https://github.com/cosmos/cosmos-sdk/pull/13502) Add Amino Msg registration for `MsgCreatePeriodicVestingAccount`.
* (x/group) [#13876](https://github.com/cosmos/cosmos-sdk/pull/13876) Fix group MinExecutionPeriod that is checked on execution now, instead on voting period end.

### API Breaking Changes

Expand Down Expand Up @@ -168,6 +169,7 @@ Ref: https://keepachangelog.com/en/1.0.0/
* [#13794](https://github.com/cosmos/cosmos-sdk/pull/13794) Most methods on `types/module.AppModule` have been moved to
extension interfaces. `module.Manager.Modules` is now of type `map[string]interface{}` to support in parallel the new
`cosmossdk.io/core/appmodule.AppModule` API.
* (x/group) [#13876](https://github.com/cosmos/cosmos-sdk/pull/13876) Add `GetMinExecutionPeriod` method on DecisionPolicy interface.

### CLI Breaking Changes

Expand Down