feat(cli): add --append flag to sign-batch cli cmd
#13147
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #13147 +/- ##
==========================================
- Coverage 55.87% 54.37% -1.51%
==========================================
Files 646 645 -1
Lines 54895 54924 +29
==========================================
- Hits 30675 29863 -812
- Misses 21762 22663 +901
+ Partials 2458 2398 -60
|
|
How is this different from |
x/auth/client/cli/tx_multisign.go
Outdated
| txBuilder.SetMemo(fe.GetTx().GetMemo()) | ||
| txBuilder.SetTip(fe.GetTx().GetTip()) | ||
| txBuilder.SetGasLimit(fe.GetTx().GetGas()) |
There was a problem hiding this comment.
We're doing this in a loop, so aren't we overriding these fields, for each tx?
There was a problem hiding this comment.
Now I am adding memo, remaining fields to tx from cmd.Flags
Oh seems like it is. @gsk967 can we merge this solution with sign-batch to accept multiple tx files. How does that sound @alexanderbez . I like some refactoring in this pr tbh |
Yeah, sure! |
How about we add a flag |
|
How would that work? Say we have a new flag, e.g. |
|
So sign-batch expects a file to have multiple unsigned txs seperated by next line. The command flow would look something like this |
|
Makes sense. But I would have all txs use the new flag so make the UX easier. If the flag is present and the file is empty, then just populate the empty file 👍 |
I think we don't need any flag to be introduced here, since we have
The following lines will do the same as above mentioned lines by @sahith-narahari . We can just update the documentation. cc: @anilcse , @alexanderbez |
|
Oh right, we can close the issue in this case then |
|
@atheeshp I don't understand how directing output will work though? The |
|
@atheeshp @alexanderbez @AmauryM @anilcse Added |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| return err | ||
| } | ||
| if ms == "" { | ||
| from, _ := cmd.Flags().GetString(flags.FlagFrom) |
Check warning
Code scanning / gosec
Returned error is not propagated up the stack.
| txBuilder, err := txCfg.WrapTxBuilder(unsignedStdTx) | ||
| if err != nil { | ||
| return err | ||
| appendMessagesToSingleMsg, _ := cmd.Flags().GetBool(flagAppend) |
Check warning
Code scanning / gosec
Returned error is not propagated up the stack.
| } | ||
| // set the new appened msgs into builder | ||
| txBuilder.SetMsgs(msgs...) |
Check warning
Code scanning / gosec
Errors unhandled.
|
Amazing! @julienrbrt or @facundomedica would be willing to help test this feature with me please? |
I can check tomorrow morning :) |
gsk967
changed the title
multi-msg-sign--append flag to sign-batch cli cmd
|
Tested and works, but if there is documentation to update, we should do it in this PR. |
|
There are definitely CLI docs that we can look to update. Doesn't have to be super in depth, but maybe just a note in a CLI doc? |
Looking at the auth docs, there is actually no documentation for any |
* feat(cli): add `multi-msg-sign` * chore: update the changelog * chore: fix the lint issue * chore: address the pr comments * chore: address the pr comments * refactor: refactored `sign-batch` to generate single signed tx * chore: updated the changelog * fix: fix the lint * test: fix the tests on auth Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
Description
Added
--appendflags tosign-batchcli cmd, this will combine the messages which are generated from--generate-onlyand it will generate single transactionref: #13066
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change