Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(x/group): propagate events correctly to current context #12888

Merged
merged 5 commits into from Aug 10, 2022
Merged

fix(x/group): propagate events correctly to current context #12888

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
942f03d
fix(x/groups) propagate events correctly to current context
damiannolan Aug 10, 2022
77452e4
update to use current context on logger
damiannolan Aug 10, 2022
f33e7ca
adding changelog entry
damiannolan Aug 10, 2022
4c89dc3
Merge branch 'main' into damian/fix-groups-exec-event-propagation
alexanderbez Aug 10, 2022
c1fbaae
Merge branch 'main' into damian/fix-groups-exec-event-propagation
alexanderbez Aug 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 9 additions & 3 deletions x/group/keeper/msg_server.go
View file
Open in desktop
Expand Up @@ -747,20 +747,26 @@ func (k Keeper) Exec(goCtx context.Context, req *group.MsgExec) (*group.MsgExecR
var logs string
if proposal.Status == group.PROPOSAL_STATUS_ACCEPTED && proposal.ExecutorResult != group.PROPOSAL_EXECUTOR_RESULT_SUCCESS {
// Caching context so that we don't update the store in case of failure.
ctx, flush := ctx.CacheContext()
cacheCtx, flush := ctx.CacheContext()

addr, err := sdk.AccAddressFromBech32(policyInfo.Address)
if err != nil {
return nil, err
}
_, err = k.doExecuteMsgs(ctx, k.router, proposal, addr)

results, err := k.doExecuteMsgs(cacheCtx, k.router, proposal, addr)
if err != nil {
proposal.ExecutorResult = group.PROPOSAL_EXECUTOR_RESULT_FAILURE
logs = fmt.Sprintf("proposal execution failed on proposal %d, because of error %s", id, err.Error())
k.Logger(ctx).Info("proposal execution failed", "cause", err, "proposalID", id)
k.Logger(cacheCtx).Info("proposal execution failed", "cause", err, "proposalID", id)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the logger use the regular context? Are these being logged?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, perhaps? It was previously using the cached context as ctx was being reassigned above.
I'm happy to change it to use current context

} else {
proposal.ExecutorResult = group.PROPOSAL_EXECUTOR_RESULT_SUCCESS
flush()

for _, res := range results {
// NOTE: The sdk msg handler creates a new EventManager, so events must be correctly propagated back to the current context
ctx.EventManager().EmitEvents(res.GetEvents())
}
}
}

Expand Down