Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Add Tips decorator in simapp #12016

Merged
merged 3 commits into from
May 23, 2022
Merged

refactor: Add Tips decorator in simapp #12016

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2b5423c
refactor: Add Tips decorator in simapp
amaury1093 May 23, 2022
4a5f3db
Fix test
amaury1093 May 23, 2022
1670def
Merge branch 'main' into am/include-tips
amaury1093 May 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 4 additions & 6 deletions simapp/app.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -454,17 +454,15 @@ func NewSimApp(
//
// The SDK exposes a default postHandlers chain, which comprises of only
// one decorator: the Transaction Tips decorator. However, some chains do
// not need it by default, so the following line is commented out. You can
// uncomment it to include the tips decorator, or define your own
// postHandler chain. To read more about tips:
// not need it by default, so feel free to comment the next line if you do
// not need tips.
// To read more about tips:
// https://docs.cosmos.network/main/core/tips.html
//
// Please note that changing any of the anteHandler or postHandler chain is
// likely to be a state-machine breaking change, which needs a coordinated
// upgrade.
//
// Uncomment to enable postHandlers:
// app.setPostHandler()
app.setPostHandler()

if loadLatest {
if err := app.LoadLatestVersion(); err != nil {
Expand Down
7 changes: 0 additions & 7 deletions x/auth/client/testutil/suite.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1562,13 +1562,6 @@ func (s *IntegrationTestSuite) TestAuxSigner() {
}

func (s *IntegrationTestSuite) TestAuxToFeeWithTips() {
// Currently, simapp doesn't have Tips decorator enabled by default in its
// posthandlers, so this test will fail.
//
// TODO Find a way to test Tips integratin test with a custom simapp with
// tips posthandler.
s.T().Skip()

require := s.Require()
val := s.network.Validators[0]

Expand Down