feat: `ScheduleUpgradeNoHeightValidation` for automated upgrades w/o gov proposal #11551

fedekunze · 2022-04-05T16:11:20Z

Description

Implements a ScheduleUpgradeNoHeightValidation function for chains to schedule an automated upgrade (using the x/upgrade module) without having to go through a governance proposal.

This is beneficial to coordinate upgrades without having to manually download the new version, do the migration and restart the chain.

This is the procedure Evmos used for its automated upgrade.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

confirmed the correct type prefix in the PR title
confirmed ! in the type prefix if API or client breaking change
confirmed all author checklist items have been addressed
reviewed state machine logic
reviewed API design and naming
reviewed documentation is accurate
reviewed tests and test coverage
manually tested (if applicable)

alexanderbez · 2022-04-05T18:27:41Z

This is for height-gated upgrade right? Like "Perform upgrade FOO and height H" without a gov prop?

This would still require a new binary for validators, but it doesn't have to be a coordinated download IIUC.

ValarDragon

I think we should just change the if plan.Height <= ctx.BlockHeight() { check to be if plan.Height < ctx.BlockHeight() {, and add a comment for why we allow it to be equal in this case.

(We allow for the possibility of chains to schedule upgrades in begin block of the same block, as a strategy for emergency hard fork recoveries)

…mos/cosmos-sdk into fedekunze/schedule-upgrade-no-height

…gov proposal (#11551) ## Description Implements a `ScheduleUpgradeNoHeightValidation` function for chains to schedule an automated upgrade (using the `x/upgrade` module) without having to go through a governance proposal. This is beneficial to coordinate upgrades without having to manually download the new version, do the migration and restart the chain. This is the procedure Evmos used for its automated upgrade. --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable) (cherry picked from commit 5b02bf4) # Conflicts: # CHANGELOG.md

…gov proposal (#11551) ## Description Implements a `ScheduleUpgradeNoHeightValidation` function for chains to schedule an automated upgrade (using the `x/upgrade` module) without having to go through a governance proposal. This is beneficial to coordinate upgrades without having to manually download the new version, do the migration and restart the chain. This is the procedure Evmos used for its automated upgrade. --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable) (cherry picked from commit 5b02bf4) # Conflicts: # CHANGELOG.md # x/upgrade/abci_test.go # x/upgrade/keeper/keeper.go

tac0turtle · 2022-04-08T10:49:17Z

@fedekunze where did ScheduleUpgradeNoHeightValidation this pr is now comment and testing fixes

fedekunze · 2022-04-08T10:51:27Z

@marbar3778 we changed the height validation to accept plans scheduled at the current height

…gov proposal (backport #11551) (#11574) * feat: `ScheduleUpgradeNoHeightValidation` for automated upgrades w/o gov proposal (#11551) ## Description Implements a `ScheduleUpgradeNoHeightValidation` function for chains to schedule an automated upgrade (using the `x/upgrade` module) without having to go through a governance proposal. This is beneficial to coordinate upgrades without having to manually download the new version, do the migration and restart the chain. This is the procedure Evmos used for its automated upgrade. --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable) (cherry picked from commit 5b02bf4) # Conflicts: # CHANGELOG.md # x/upgrade/abci_test.go # x/upgrade/keeper/keeper.go * fix conflicts * changelog * fix test Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> Co-authored-by: Federico Kunze Küllmer <federico.kunze94@gmail.com>

…gov proposal (backport #11551) (#11573) * feat: `ScheduleUpgradeNoHeightValidation` for automated upgrades w/o gov proposal (#11551) ## Description Implements a `ScheduleUpgradeNoHeightValidation` function for chains to schedule an automated upgrade (using the `x/upgrade` module) without having to go through a governance proposal. This is beneficial to coordinate upgrades without having to manually download the new version, do the migration and restart the chain. This is the procedure Evmos used for its automated upgrade. --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable) (cherry picked from commit 5b02bf4) # Conflicts: # CHANGELOG.md * fix conflicts Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> Co-authored-by: Federico Kunze Küllmer <federico.kunze94@gmail.com>

assafmo · 2022-04-12T21:35:55Z

Are there any docs for using it?

Allow ScheduleUpgrade to come from same block

* Cherry-pick of cosmos#11551 Allow ScheduleUpgrade to come from same block * Fix test

* Cherry-pick of cosmos#11551 Allow ScheduleUpgrade to come from same block * Fix test (cherry picked from commit a2805f4)

…gov proposal (backport cosmos#11551) (cosmos#11574) * feat: `ScheduleUpgradeNoHeightValidation` for automated upgrades w/o gov proposal (cosmos#11551) ## Description Implements a `ScheduleUpgradeNoHeightValidation` function for chains to schedule an automated upgrade (using the `x/upgrade` module) without having to go through a governance proposal. This is beneficial to coordinate upgrades without having to manually download the new version, do the migration and restart the chain. This is the procedure Evmos used for its automated upgrade. --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable) (cherry picked from commit 5b02bf4) # Conflicts: # CHANGELOG.md # x/upgrade/abci_test.go # x/upgrade/keeper/keeper.go * fix conflicts * changelog * fix test Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> Co-authored-by: Federico Kunze Küllmer <federico.kunze94@gmail.com>

…gov proposal (backport cosmos#11551) (cosmos#11574) * feat: `ScheduleUpgradeNoHeightValidation` for automated upgrades w/o gov proposal (cosmos#11551) Implements a `ScheduleUpgradeNoHeightValidation` function for chains to schedule an automated upgrade (using the `x/upgrade` module) without having to go through a governance proposal. This is beneficial to coordinate upgrades without having to manually download the new version, do the migration and restart the chain. This is the procedure Evmos used for its automated upgrade. --- *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable) (cherry picked from commit 5b02bf4) * fix conflicts * changelog * fix test Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> Co-authored-by: Federico Kunze Küllmer <federico.kunze94@gmail.com>

imp: ScheduleUpgradeNoHeightValidation for automated unplanned upgrades

d07b424

fedekunze changed the title ~~imp: ScheduleUpgradeNoHeightValidation for automated unplanned upgrades~~ imp: ScheduleUpgradeNoHeightValidation for automated unplanned upgrades Apr 5, 2022

github-actions bot added the C:x/upgrade label Apr 5, 2022

fedekunze changed the title ~~imp: ScheduleUpgradeNoHeightValidation for automated unplanned upgrades~~ imp: ScheduleUpgradeNoHeightValidation for automated upgrades w/o gov proposal Apr 5, 2022

changelog

26fadcb

fedekunze marked this pull request as ready for review April 5, 2022 16:16

fedekunze requested review from aaronc and alexanderbez as code owners April 5, 2022 16:16

fedekunze requested review from ValarDragon, tac0turtle, robert-zaremba and anilcse April 5, 2022 16:16

fedekunze changed the title ~~imp: ScheduleUpgradeNoHeightValidation for automated upgrades w/o gov proposal~~ feat: ScheduleUpgradeNoHeightValidation for automated upgrades w/o gov proposal Apr 5, 2022

fedekunze requested review from sunnya97 and amaury1093 April 5, 2022 17:14

Merge branch 'master' into fedekunze/schedule-upgrade-no-height

684a039

ValarDragon requested changes Apr 5, 2022

View reviewed changes

address comments

9936c02

fedekunze requested a review from ValarDragon April 6, 2022 07:55

Merge branch 'master' into fedekunze/schedule-upgrade-no-height

449bc6c

fedekunze added A:automerge Automatically merge PR once all prerequisites pass. backport/0.46.x PR scheduled for inclusion in the v0.46's next stable release backport/0.45.x labels Apr 6, 2022

Merge branch 'master' into fedekunze/schedule-upgrade-no-height

15a85d6

alexanderbez approved these changes Apr 6, 2022

View reviewed changes

amaury1093 self-assigned this Apr 6, 2022

ValarDragon approved these changes Apr 6, 2022

View reviewed changes

tac0turtle and others added 2 commits April 6, 2022 23:00

Merge branch 'master' into fedekunze/schedule-upgrade-no-height

d9f8b43

fix tests

91df92c

fedekunze and others added 2 commits April 7, 2022 12:52

Merge branch 'fedekunze/schedule-upgrade-no-height' of github.com:cos…

819d468

…mos/cosmos-sdk into fedekunze/schedule-upgrade-no-height

Merge branch 'master' into fedekunze/schedule-upgrade-no-height

d9c8c09

mergify bot merged commit 5b02bf4 into master Apr 7, 2022

mergify bot deleted the fedekunze/schedule-upgrade-no-height branch April 7, 2022 17:00

mergify bot mentioned this pull request Apr 7, 2022

feat: ScheduleUpgradeNoHeightValidation for automated upgrades w/o gov proposal (backport #11551) #11573

Merged

mergify bot mentioned this pull request Apr 7, 2022

feat: ScheduleUpgradeNoHeightValidation for automated upgrades w/o gov proposal (backport #11551) #11574

Merged

ValarDragon added a commit to osmosis-labs/cosmos-sdk that referenced this pull request Jun 9, 2022

Cherry-pick of cosmos#11551

4c96c64

Allow ScheduleUpgrade to come from same block

ValarDragon mentioned this pull request Jun 9, 2022

fix: Allow ScheduleUpgrade to come from same block osmosis-labs/cosmos-sdk#260

Merged

ValarDragon added a commit to osmosis-labs/cosmos-sdk that referenced this pull request Jun 10, 2022

Cherry-pick of cosmos#11551

72b82b1

Allow ScheduleUpgrade to come from same block

p0mvn pushed a commit to osmosis-labs/cosmos-sdk that referenced this pull request Jun 10, 2022

fix: Allow ScheduleUpgrade to come from same block (#260)

a2805f4

* Cherry-pick of cosmos#11551 Allow ScheduleUpgrade to come from same block * Fix test

mergify bot pushed a commit to osmosis-labs/cosmos-sdk that referenced this pull request Jun 10, 2022

fix: Allow ScheduleUpgrade to come from same block (#260)

6dd36b5

* Cherry-pick of cosmos#11551 Allow ScheduleUpgrade to come from same block * Fix test (cherry picked from commit a2805f4)

LampardNguyen234 mentioned this pull request Aug 15, 2023

deps: bump cosmos-sdk v0.46 and evmos v12 AstraProtocol/astra#209

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: `ScheduleUpgradeNoHeightValidation` for automated upgrades w/o gov proposal #11551

feat: `ScheduleUpgradeNoHeightValidation` for automated upgrades w/o gov proposal #11551

fedekunze commented Apr 5, 2022 •

edited

alexanderbez commented Apr 5, 2022

ValarDragon left a comment

tac0turtle commented Apr 8, 2022

fedekunze commented Apr 8, 2022

assafmo commented Apr 12, 2022

feat: ScheduleUpgradeNoHeightValidation for automated upgrades w/o gov proposal #11551

feat: ScheduleUpgradeNoHeightValidation for automated upgrades w/o gov proposal #11551

Conversation

fedekunze commented Apr 5, 2022 • edited

Description

Author Checklist

Reviewers Checklist

alexanderbez commented Apr 5, 2022

ValarDragon left a comment

Choose a reason for hiding this comment

tac0turtle commented Apr 8, 2022

fedekunze commented Apr 8, 2022

assafmo commented Apr 12, 2022

feat: `ScheduleUpgradeNoHeightValidation` for automated upgrades w/o gov proposal #11551

feat: `ScheduleUpgradeNoHeightValidation` for automated upgrades w/o gov proposal #11551

fedekunze commented Apr 5, 2022 •

edited