Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add metadata field to Vote in x/gov #11308

Merged
merged 9 commits into from Mar 3, 2022

Conversation

likhita-809
Copy link
Contributor

Description

Closes: #11268

Add metadata to Vote in x/gov using the existing maxMetadataLen constraint.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@likhita-809 likhita-809 changed the title Likhita/gov add metadata to vote feat: Add metadata field to Vote in x/gov Mar 2, 2022
@codecov
Copy link

codecov bot commented Mar 2, 2022

Codecov Report

Merging #11308 (03dcae4) into master (da36c46) will decrease coverage by 0.05%.
The diff coverage is 39.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11308      +/-   ##
==========================================
- Coverage   65.98%   65.93%   -0.06%     
==========================================
  Files         696      662      -34     
  Lines       71310    68527    -2783     
==========================================
- Hits        47055    45180    -1875     
+ Misses      21340    20702     -638     
+ Partials     2915     2645     -270     
Impacted Files Coverage Δ
server/rollback.go 0.00% <0.00%> (ø)
store/rootmulti/store.go 73.52% <0.00%> (-2.00%) ⬇️
x/gov/client/cli/tx.go 14.28% <0.00%> (-0.61%) ⬇️
x/gov/keeper/msg_server.go 6.57% <0.00%> (ø)
x/gov/types/v1beta2/vote.go 27.27% <0.00%> (ø)
x/gov/keeper/vote.go 89.28% <50.00%> (-3.22%) ⬇️
x/gov/client/testutil/suite.go 100.00% <100.00%> (ø)
x/gov/keeper/keeper.go 77.10% <100.00%> (+1.46%) ⬆️
x/gov/keeper/proposal.go 77.97% <100.00%> (+0.13%) ⬆️
x/gov/simulation/operations.go 85.31% <100.00%> (ø)
... and 37 more

@likhita-809 likhita-809 marked this pull request as ready for review March 2, 2022 10:24
x/gov/client/cli/tx.go Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
x/gov/client/cli/tx.go Outdated Show resolved Hide resolved
x/gov/keeper/vote.go Outdated Show resolved Hide resolved
x/gov/client/cli/tx.go Outdated Show resolved Hide resolved
x/gov/client/cli/tx.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@anilcse anilcse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@amaury1093 amaury1093 added the A:automerge Automatically merge PR once all prerequisites pass. label Mar 3, 2022
@mergify mergify bot merged commit 918330b into master Mar 3, 2022
@mergify mergify bot deleted the likhita/gov-add-metadata-to-vote branch March 3, 2022 14:38
@amaury1093 amaury1093 mentioned this pull request May 20, 2022
72 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:CLI C:Simulations C:x/auth C:x/gov
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add metadata to Vote in x/gov
4 participants