Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: always move auth module migration to the end #10608

Merged
merged 6 commits into from Nov 25, 2021
Merged

fix: always move auth module migration to the end #10608

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
af06f2f
fix: always move auth module migration to the end
robert-zaremba Nov 24, 2021
37f75ce
update migration docs
robert-zaremba Nov 25, 2021
a5da53a
adding changelog
robert-zaremba Nov 25, 2021
ad93134
update docs
robert-zaremba Nov 25, 2021
be21534
review updates
robert-zaremba Nov 25, 2021
1fb4959
Update CHANGELOG.md
robert-zaremba Nov 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 10 additions & 1 deletion types/module/module.go
View file
Open in desktop
Expand Up @@ -395,10 +395,19 @@ func (m Manager) RunMigrations(ctx sdk.Context, cfg Configurator, fromVM Version
// and the order of executing migrations matters)
// TODO: make the order user-configurable?
sortedModNames := make([]string, 0, len(m.Modules))
hasAuth := false
const authModulename = "auth" // using authtypes.ModuleName causes import cycle.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it smells, but moving it to refactoring this packages is no go for merging it in 0.44.x

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a TODO for future scope?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO doesn't make sense here because this is merged only for 0.44.x, not in master.

for key := range m.Modules {
sortedModNames = append(sortedModNames, key)
if key != authModulename {
sortedModNames = append(sortedModNames, key)
} else {
hasAuth = true
}
}
sort.Strings(sortedModNames)
if hasAuth {
sortedModNames = append(sortedModNames, authModulename)
}

for _, moduleName := range sortedModNames {
module := m.Modules[moduleName]
Expand Down