Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: lint go and markdown (backport #10060) #10473

Merged
merged 3 commits into from Nov 11, 2021

Commits on Oct 30, 2021

  1. style: lint go and markdown (#10060)

    ## Description
    
    + fixing `x/bank/migrations/v44.migrateDenomMetadata` - we could potentially put a wrong data in a new key if the old keys have variable length.
    + linting the code
    
    Putting in the same PR because i found the issue when running a linter.
    
    Depends on: #10112
    
    ---
    
    ### Author Checklist
    
    *All items are required. Please add a note to the item if the item is not applicable and
    please add links to any relevant follow up issues.*
    
    I have...
    
    - [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
    - [x] added `!` to the type prefix if API or client breaking change
    - [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting))
    - [ ] provided a link to the relevant issue or specification
    - [x] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules)
    - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing)
    - [ ] added a changelog entry to `CHANGELOG.md`
    - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
    - [ ] updated the relevant documentation or specification
    - [ ] reviewed "Files changed" and left comments if necessary
    - [ ] confirmed all CI checks have passed
    
    ### Reviewers Checklist
    
    *All items are required. Please add a note if the item is not applicable and please add
    your handle next to the items reviewed if you only reviewed selected items.*
    
    I have...
    
    - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
    - [ ] confirmed `!` in the type prefix if API or client breaking change
    - [ ] confirmed all author checklist items have been addressed
    - [ ] reviewed state machine logic
    - [ ] reviewed API design and naming
    - [ ] reviewed documentation is accurate
    - [ ] reviewed tests and test coverage
    - [ ] manually tested (if applicable)
    
    (cherry picked from commit 479485f)
    
    # Conflicts:
    #	CODING_GUIDELINES.md
    #	CONTRIBUTING.md
    #	STABLE_RELEASES.md
    #	contrib/rosetta/README.md
    #	cosmovisor/README.md
    #	crypto/keyring/keyring.go
    #	db/README.md
    #	docs/404.md
    #	docs/DOCS_README.md
    #	docs/architecture/adr-038-state-listening.md
    #	docs/architecture/adr-040-storage-and-smt-state-commitments.md
    #	docs/architecture/adr-043-nft-module.md
    #	docs/architecture/adr-044-protobuf-updates-guidelines.md
    #	docs/architecture/adr-046-module-params.md
    #	docs/migrations/pre-upgrade.md
    #	docs/migrations/rest.md
    #	docs/ru/README.md
    #	docs/run-node/rosetta.md
    #	docs/run-node/run-node.md
    #	docs/run-node/run-testnet.md
    #	go.mod
    #	scripts/module-tests.sh
    #	snapshots/README.md
    #	store/streaming/README.md
    #	store/streaming/file/README.md
    #	store/v2/flat/store.go
    #	store/v2/smt/store.go
    #	x/auth/ante/sigverify.go
    #	x/auth/middleware/basic.go
    #	x/auth/spec/01_concepts.md
    #	x/auth/spec/05_vesting.md
    #	x/auth/spec/07_client.md
    #	x/authz/spec/05_client.md
    #	x/bank/spec/README.md
    #	x/crisis/spec/05_client.md
    #	x/distribution/spec/README.md
    #	x/epoching/keeper/keeper.go
    #	x/epoching/spec/03_to_improve.md
    #	x/evidence/spec/07_client.md
    #	x/feegrant/spec/README.md
    #	x/gov/spec/01_concepts.md
    #	x/gov/spec/07_client.md
    #	x/group/internal/orm/spec/01_table.md
    #	x/mint/spec/06_client.md
    #	x/slashing/spec/09_client.md
    #	x/slashing/spec/README.md
    #	x/staking/spec/09_client.md
    #	x/upgrade/spec/04_client.md
    robert-zaremba authored and mergify-bot committed Oct 30, 2021
    Copy the full SHA
    b1718a7 View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2021

  1. fix conflicts

    robert-zaremba committed Nov 11, 2021
    Copy the full SHA
    abe3ddf View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    ae8645b View commit details
    Browse the repository at this point in the history