Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Fix inconsistent gas multiplier value between signAndBroadcast and signAndBroadcastSync methods #1584

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

🐛 Fix inconsistent gas multiplier value between signAndBroadcast and signAndBroadcastSync methods #1584

wants to merge 2 commits into from

Conversation

AlexanderFSP
Copy link

@AlexanderFSP AlexanderFSP commented Apr 29, 2024 •
edited

Synchronizes the gas multiplier value between the #signAndBroadcast and #signAndBroadcastSync methods so that it is equal to 1.4 everywhere.

webmaster128
webmaster128 reviewed Apr 30, 2024
View reviewed changes
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the renaming. Could you add a CHANGELOG entry to the Unreleased section?

packages/cosmwasm-stargate/src/signingcosmwasmclient.ts Outdated Show resolved Hide resolved
packages/stargate/src/signingstargateclient.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webmaster128 webmaster128 Awaiting requested review from webmaster128

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AlexanderFSP @webmaster128