Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt codebase to work with wasmd 0.50 (Cosmos SDK 0.50) #1564

Merged
merged 15 commits into from
Mar 8, 2024
Merged

Conversation

webmaster128
Copy link
Member

@webmaster128 webmaster128 commented Feb 28, 2024

Closes #1562

@pynixwang
Copy link
Contributor

can we move common field in to common interface

interface TransactionResult {
  /** @deprecated Not filled in Cosmos SDK >= 0.50. Use events instead. */
  readonly logs: readonly logs.Log[];
  /** Block height in which the transaction is included */
  readonly height: number;
  /** Transaction hash (might be used as transaction ID). Guaranteed to be non-empty upper-case hex */
  readonly transactionHash: string;
  readonly events: readonly Event[];
  readonly gasWanted: bigint;
  readonly gasUsed: bigint;
}

do not repeat on every interface such as upload, execute, change admin.

@webmaster128
Copy link
Member Author

can we move common field in to common interface

Why do you think this is needed? Could you open a separate issue for that?

@webmaster128
Copy link
Member Author

I'm merging this work now and do a patch release. This should provide some basic Cosmos SDK 0.50 support for CosmWasm. However, it looks like Amino JSON is broken for many cases with Cosmos SDK 0.50, including CosmWasm message types. But this is the case for all 0.32.x releases.

@webmaster128 webmaster128 merged commit f94b230 into main Mar 8, 2024
16 checks passed
@webmaster128 webmaster128 deleted the wasmd-0.50 branch March 8, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rawLog is deprecated
2 participants