chore: make integers errors more explicit #1314
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For easy debugging.
packages/math/src/integers.ts
Outdated
| @@ -55,7 +55,7 @@ export class Uint32 implements Integer, WithByteConverters { | |||
|
|
|||
| public static fromString(str: string): Uint32 { | |||
| if (!str.match(/^[0-9]+$/)) { | |||
| throw new Error("Invalid string format"); | |||
| throw new Error("Invalid string format. Found: " + str); | |||
There was a problem hiding this comment.
Can you put the values in quotes? This makes it easier to find begin and end in the error messages and allows debugging empty string inputs.
Probably easier to write with a template string.
throw new Error(`Invalid string format. Found: '${str}'`);Thanks
There was a problem hiding this comment.
I had also thought about it, but I based it on
cosmjs/packages/math/src/integers.ts
Line 204 in 2c3b27e
I will adapt to reflect your suggestion.
packages/math/src/integers.ts
Outdated
| @@ -238,10 +238,10 @@ export class Uint64 implements Integer, WithByteConverters { | |||
|
|
|||
| private constructor(data: BN) { | |||
| if (data.isNeg()) { | |||
| throw new Error("Input is negative"); | |||
| throw new Error("Input is negative. Found: " + data); | |||
There was a problem hiding this comment.
Does that give you a proper debug representation of a BN?
There was a problem hiding this comment.
I don't think so, I will adapt this with the call toString()
|
Should be good @webmaster128 |
|
any news @webmaster128? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For easy debugging.