Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump target to ES2018 #1018

Merged
merged 1 commit into from
Jan 27, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ and this project adheres to

### Changed

- all: The TypeScript compilation target is now ES2018.
- @cosmjs/stargate: The `AminoTypes` now always requires an argument of type
`AminoTypesOptions`. This is an object with a required `prefix` field. Before
the prefix defaulted to "cosmos" but this is almost never the right choice for
Expand Down
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -90,12 +90,12 @@ Currently the codebase supports the following runtime environments:
[Edge Spartan](https://en.wikipedia.org/wiki/Microsoft_Edge#Development))
3. Browser extensions (Chromium/Firefox)

Our current JavaScript target standard is ES2017, giving us native async/await
support. We use WebAssembly to implement certain cryptographic functions.
Our current JavaScript target standard is ES2018. We use WebAssembly to
implement certain cryptographic functions.

We're happy to adjust this list according to users' needs as long as you don't
ask for Internet Explorer support. If your environment does not support Wasm, we
can work on a solution with swapable implementations.
can work on a solution with swappable implementations.

## Roadmap

Expand Down
2 changes: 1 addition & 1 deletion packages/cli/tsconfig_repl.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"esModuleInterop": true,
"module": "commonjs",
"moduleResolution": "node",
"target": "es2017",
"target": "es2018",
"noUnusedLocals": false,
"noImplicitAny": false
}
Expand Down
4 changes: 1 addition & 3 deletions packages/json-rpc/src/compatibility.ts
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,5 @@ export function isJsonCompatibleDictionary(data: unknown): data is JsonCompatibl
return false;
}

// TODO: replace with Object.values when available (ES2017+)
const values = Object.getOwnPropertyNames(data).map((key) => (data as any)[key]);
return values.every(isJsonCompatibleValue);
return Object.values(data).every(isJsonCompatibleValue);
}
2 changes: 1 addition & 1 deletion packages/ledger-amino/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"baseUrl": ".",
"outDir": "build",
"rootDir": "src",
"lib": ["es2017", "dom"]
"lib": ["es2018", "dom"]
},
"include": ["src/**/*"]
}
6 changes: 3 additions & 3 deletions tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@
"declaration": true,
"esModuleInterop": true,
"forceConsistentCasingInFileNames": true,
"lib": ["es2017"],
"lib": ["es2018"],
"target": "es2018",
"module": "commonjs",
"moduleResolution": "node",
"newLine": "LF",
Expand All @@ -18,7 +19,6 @@
"removeComments": false,
"resolveJsonModule": true,
"sourceMap": true,
"strict": true,
"target": "es2017"
"strict": true
}
}