Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Amino JSON for commission_rate/min_self_delegation #1304

Merged
merged 1 commit into from Oct 25, 2022
Merged

Fix Amino JSON for commission_rate/min_self_delegation #1304

merged 1 commit into from Oct 25, 2022

Conversation

webmaster128
Copy link
Member

Closes #1299

@webmaster128 webmaster128 mentioned this pull request Oct 24, 2022
Closed
@webmaster128 webmaster128 added this to the 0.29.x milestone Oct 24, 2022
zakarialounes
zakarialounes reviewed Oct 25, 2022
View reviewed changes
CHANGELOG.md Outdated

- @cosmjs/stargate: Fix Amino JSON encoding of the unset case of
`commission_rate` and `min_self_delegation` in
`MsgEditValidator`/`AminoMsgCreateValidator`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MsgEditValidator/AminoMsgEditValidator

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@webmaster128 webmaster128 merged commit d03116e into main Oct 25, 2022
@webmaster128 webmaster128 deleted the fix-AminoMsgEditValidator branch October 25, 2022 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zakarialounes zakarialounes zakarialounes left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.29.x
Development

Successfully merging this pull request may close these issues.

MsgEditValidator not possible
2 participants
@webmaster128 @zakarialounes