Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MsgEditValidator not possible #1299

Closed
zakarialounes opened this issue Oct 20, 2022 · 8 comments · Fixed by #1304
Closed

MsgEditValidator not possible #1299

zakarialounes opened this issue Oct 20, 2022 · 8 comments · Fixed by #1304

Comments

@zakarialounes
Copy link
Contributor

The use of the message MsgEditValidator is not possible, here is the error received:

Log: signature verification failed; please verify account number (XX), sequence (XX) and chain-id (XX): unauthorized
    at SigningStargateClient.broadcastTx (stargateclient.js?d2d5:265:1)

No problem with other types of messages. It is possible to do the test directly via https://ezstaking.tools/wallet#validator.

Thanks in advance

@webmaster128
Copy link
Member

@zakarialounes
Copy link
Contributor Author

zakarialounes commented Oct 24, 2022

Thanks for answering me @webmaster128.

  • Which sign node are you using?

Sign mode? getOfflineSignerAuto

  • Did you upgrade to CosmJS 0.29.2?

I only updated yesterday from 0.29.1 to 0.29.2, I will try again.

I did not follow this example, but I have the same thing.

@zakarialounes
Copy link
Contributor Author

Ok, it works with version 0.29.2! Thanks a lot @webmaster128.

However, if I don't increase the value of min-self-delegation I get an error message telling me that it's not possible to reduce it, even though I haven't modified it.

@webmaster128
Copy link
Member

if I don't increase the value of min-self-delegation I get an error message telling me that it's not possible to reduce it, even though I haven't modified it.

This is a tricky one. In theory there should be a way to not set the fields commission_rate and min_self_delegation at all and exclude them from the update. Unfortunately I don't know how to encode this in the protobuf API.

@webmaster128
Copy link
Member

Could you try setting both commission_rate and min_self_delegation to empty strings? That might be the way to not update them.

@webmaster128
Copy link
Member

I wrote a test myself. Turns out it works for sign mode direct but not Amino JSON. #1304 adds test cases for that and fixes the Amino JSON encoding.

@zakarialounes
Copy link
Contributor Author

Sorry I just saw your notification @webmaster128 I had already done the test with a validator managed via Ledger and it didn't work, I had even tried to define undefined/null. But obviously it was at the level of the toAmino which converted any value received into a string. Thanks a lot for this correction 👐

@webmaster128
Copy link
Member

Fix should be available in version 0.29.3 now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants