-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update TIA chain.json #4520
base: master
Are you sure you want to change the base?
Update TIA chain.json #4520
Conversation
Updated explorer links that are using ping.pub to use type ping.pub
"kind" is a little misleading here, but the "kind" should refer to the host of the explorer (in this case Stavr and NodeStake) rather than what is used as the base. |
It's obviously not my choice what "kind" is but as a DApp developer, when i first encountered "kind" key here I thought about "type". You can reject the PR if i misunderstood. But in this case I want to suggest adding a new key called "gov_proposal_page" (like "tx_page" and "account_page"), so developers like me can use any explorer when they want to redirect the user to a proposal page. I had to pick ping.pub since it's the most popular and I can guess the URL to the gov proposal page. I honestly thought it's a no brainer what "kind" means. :) |
As you can see when I submitted this file https://github.com/cosmos/chain-registry/blob/master/beezee/chain.json 1 year ago "ping.pub" was accepted as "kind". Now I have to find a fallback when i don't find "ping.pub" kind for a chain LOL |
@JeremyParish69 do you have thoughts on adding these for explorer entries? Makes sense to me. |
I'm we should keep it to reflect 'host' as much as possible and move away from 'kind'. If I had the time I'd push for renaming the property for the whole registry |
I'm more so speaking on his point adding "gov_proposal_page" to explorers. |
oh, I see. I want originally going to expand to include many pages, and "proposal_page" was one of them. |
Updated explorer links that are using ping.pub to use type ping.pub