Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update assetlist.json #4408

Closed
wants to merge 2 commits into from
Closed

Update assetlist.json #4408

wants to merge 2 commits into from

Conversation

clonefund
Copy link
Contributor

add CLON

}
]
},

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't add blank lines

@@ -129,6 +129,35 @@
}
]
},

{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please relocate this object to the bottom of the list

"exponent": 6
}
],
"base": "ibc/695B1D16DE4D0FD293E6B79451640974080B59AA60942974C1CC906568DED795",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because this is an IBC asset, please define the traces so when know where it's from

"coingecko_id": "CLON",
"images": [
{
"png": "https://raw.githubusercontent.com/cosmos/chain-registry/master/terra2/images/clon1.png"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please include image_sync for images from another chain's /images/ directory

"logo_URIs": {
"png": "https://raw.githubusercontent.com/cosmos/chain-registry/master/terra2/images/clon1.png"
},
"coingecko_id": "CLON",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This cgid does not exist. Please remove.

@JeremyParish69
Copy link
Collaborator

Please use a descriptive PR title.

@JeremyParish69 JeremyParish69 marked this pull request as draft April 15, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants