Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update coingecko c4e #4296

Merged
merged 2 commits into from
May 17, 2024
Merged

Update coingecko c4e #4296

merged 2 commits into from
May 17, 2024

Conversation

pablokulpa
Copy link
Contributor

No description provided.

@@ -21,7 +21,7 @@
"logo_URIs": {
"png": "https://raw.githubusercontent.com/cosmos/chain-registry/master/chain4energy/images/c4e.png"
},
"coingecko_id": "",
"coingecko_id": "chain4energy",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cgid isn't in CoinGecko's API.
https://api.coingecko.com/api/v3/coins/list

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pablokulpa pablokulpa reopened this May 14, 2024
@pablokulpa pablokulpa marked this pull request as ready for review May 14, 2024 05:18
Copy link
Contributor

@ankurdotb ankurdotb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This ID does show up on CoinGecko API now. Although, it's still a preview token with no price. Not sure if that makes a difference per se to the chain registry though.

@JeremyParish69 JeremyParish69 merged commit 1a28e29 into cosmos:master May 17, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants