Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TAKUMI to Neutron asset list.json #4231

Merged
merged 4 commits into from
May 27, 2024
Merged

Conversation

NEXXGENAI
Copy link
Contributor

Add TAKUMI to Neutron asset list

Add TAKUMI to Neutron asset list
@JeremyParish69
Copy link
Collaborator

Please fix the schema, please use appropriate PR title, please add token logo image in the same PR.

@JeremyParish69 JeremyParish69 marked this pull request as draft March 29, 2024 20:28
Updated schema for TAKUMI on Neutron
@NEXXGENAI
Copy link
Contributor Author

takumi

@NEXXGENAI
Copy link
Contributor Author

Please fix the schema, please use appropriate PR title, please add token logo image in the same PR.

I've updated the schema, title and added a token logo.

  • Paul

@JeremyParish69
Copy link
Collaborator

Please add the token in this PR (not as a comment in the discussions, but into the appropriate directory).
Also please use an appropriate PR title, and not the generic commit text.

@NEXXGENAI NEXXGENAI changed the title Update assetlist.json Add TAKUMI to Neutron asset list.json Apr 5, 2024
@NEXXGENAI
Copy link
Contributor Author

Please add the token in this PR (not as a comment in the discussions, but into the appropriate directory). Also please use an appropriate PR title, and not the generic commit text.

I changed the PR title, but I am having trouble with getting the logo file to upload. Are you able to help? I edited the image size to 250x250 as seen below.

takumi

@JeremyParish69
Copy link
Collaborator

I changed the PR title, but I am having trouble with getting the logo file to upload. Are you able to help? I edited the image size to 250x250 as seen below.

In your branch, NEXXGENAI:patch-4, you go to the neutron/images/ directory and upload there.

@NEXXGENAI
Copy link
Contributor Author

I changed the PR title, but I am having trouble with getting the logo file to upload. Are you able to help? I edited the image size to 250x250 as seen below.

In your branch, NEXXGENAI:patch-4, you go to the neutron/images/ directory and upload there.

Done, thank you. I had clicked on add file instead of upload by mistake for the image file. Anything else that needs correcting?

Paul

@JeremyParish69
Copy link
Collaborator

Done, thank you. I had clicked on add file instead of upload by mistake for the image file. Anything else that needs correcting?

I think it's otherwise fine now, although the image really should have a square aspect ratio. And maybe the name is meant to be "Takumi Asano" (currently name is just "takumi")

@JeremyParish69 JeremyParish69 marked this pull request as ready for review May 27, 2024 18:43
@JeremyParish69 JeremyParish69 merged commit 903a47e into cosmos:master May 27, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants