Include a top-level chainlists #3850
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refundvalidator
force-pushed
the
master
branch
2 times, most recently
from
9ee9fba
to
8ba9ec5
Compare
refundvalidator
force-pushed
the
master
branch
from
8ba9ec5
to
3590695
Compare
|
Seems redundant since Github provides an API to fetch the contents of a repository as JSON? Although yes, I do understand that the JSON generated by this bash script will be simpler than the one from Github's API. I'm just not sure how big of a problem it is or not addressed downstream in clients using Github-specific packages for parsing this repo. |
|
IMO it's extra complexity, and maintenance, and makes structure changes harder to implement. I think there are several tools that can derive chain names without needing this top-level chainlist. |
|
For now I think we should leave this to tooling. Can be brought up for discussion again, but for now I'm closing this PR because it's just sitting here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes to add top-level chain lists for both mainnets, and testnets. This would allow for simpler querying when retrieving data directly from GitHub.