Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to import parts of your configuration from other files #295

Merged
merged 7 commits into from
Oct 1, 2023

Conversation

d-fischer
Copy link
Member

@d-fischer d-fischer commented Mar 6, 2023

Fixes #292

Still needs to complete the requirements list, as well as some tests for a few of the requirements.

Requirements

  • The $import special key should instruct the loader to load the given file(s) using the same explorer the consumer used, and merge your own configuration into it
    • Tests
  • Your own configuration should take priority over any imported file(s)
    • Tests
  • $import should be able to contain a string directly, or an array of strings
    • Tests
  • When importing multiple files, the last one takes priority
    • Tests
  • Nested importing should be possible, i.e. you should be able to $import a configuration file which itself uses $import
    • Tests
  • There should be a circular dependency check - loops of any size should lead to an error being thrown
    • Tests
  • You should be able to $import files of a different format than the one you're using
    • Tests
  • There should be a configuration option for the consumer that determines how to handle arrays on the same object key
    • Tests

@d-fischer d-fischer marked this pull request as ready for review June 4, 2023 20:08
@d-fischer d-fischer changed the base branch from main to v9 October 1, 2023 19:24
@d-fischer d-fischer merged commit 73284bc into v9 Oct 1, 2023
12 checks passed
@d-fischer d-fischer deleted the imports branch October 1, 2023 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make it possible to import parts of your configuration from other files
1 participant