Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable flask-cors to work well with CDNs and caches #293

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Enable flask-cors to work well with CDNs and caches #293

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 3 additions & 9 deletions flask_cors/core.py
View file
Open in desktop
Expand Up @@ -208,15 +208,9 @@ def get_cors_headers(options, request_headers, request_method):

# http://www.w3.org/TR/cors/#resource-implementation
if options.get('vary_header'):
# Only set header if the origin returned will vary dynamically,
# i.e. if we are not returning an asterisk, and there are multiple
# origins that can be matched.
if headers[ACL_ORIGIN] == '*':
pass
elif (len(options.get('origins')) > 1 or
len(origins_to_set) > 1 or
any(map(probably_regex, options.get('origins')))):
headers.add('Vary', 'Origin')
# Always set a vary header, so that intermediate caches know
# that there might be varying versions of this resource.
headers.add('Vary', 'Origin')

return MultiDict((k, v) for k, v in headers.items() if v)

Expand Down