add support for a dynamic origin #282
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the origins option can now be a function returning a string, a regex or a list. Typical usecase is to allow the application to dynamically determine what the Access-Control-Allow-Origin should be, instead of injecting the full list of allowed values at app startup.
|
@corydolphin Any chance to have this reviewed ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Fixes #281
Very close to #268 but I need to inject to request's origin in order to dynamically match the origin against a dynamic list.
Also added some unit tests.
What
the origins option can now be a function returning a string, a regex or
a list. Typical usecase is to allow the application to dynamically
determine what the Access-Control-Allow-Origin should be, instead of
injecting the full list of allowed values at app startup.