Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update code to fix almost all pre-existing lint errors #2008
Update code to fix almost all pre-existing lint errors #2008
Changes from all commits
0fc660e
43520a2
c3564f3
782bd54
18d997f
a60dcbb
2a3a929
e77ea36
62b7efd
ff69505
b666336
fb4161c
ac3f181
e8413ff
9bfd5ef
2dd3252
4dfa046
a8e0f53
0e81880
4d3838f
c8e8f56
aa2ecc6
5d857af
f48805a
6e5b06f
f910457
7d4ef02
eea746e
71c71e2
2e09e2c
fec6e23
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I question why Store() has no error return.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW from
pkg/chunk/cache/cache.go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bboreham just double checking are we good with this?? as per the comment above it was very intentional.