cbindgen: Remove CARGO_PACKAGE parameter #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC @Rikorose (since the original PR was from you) |
`CARGO_PACKAGE` was added in corrosion-rs#452 to work around the package name and crate name being different. Since b11a33 corrosion saves the package name as a target property, which we can use in `corrosion_experimental_cbindgen`. This allows us to remove the `CARGO_PACKAGE` parameter.
jschwe
force-pushed
the
jschwender/cbindgen_rm_cargo_package
branch
from
fffec4d
to
43336b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CARGO_PACKAGEwas added in #452 to work around the package name and crate name (potentially) being different.Since b11a33 corrosion saves the package name as a target property, which we can use in
corrosion_experimental_cbindgen. This allows us to remove theCARGO_PACKAGEparameter.