Breaking: Backport #514 to the stable branch #516
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jschwe
changed the title
jschwe
changed the title
jschwe
force-pushed
the
jschwender/backport_underscore
branch
from
45019e5
to
af71bc5
Compare
jschwe
changed the title
jschwe
force-pushed
the
jschwender/backport_underscore
branch
from
3721a2b
to
844af1e
Compare
jschwe
changed the title
jschwe
changed the title
jschwe
force-pushed
the
jschwender/backport_underscore
branch
from
844af1e
to
3d6eb13
Compare
Rust 1.79 and newer replace dashes with underscores in lib names. This can only happen when the lib name is inherited from the package name, since explicit lib names have never been allowed to use dashes. Since we import our CMake target names by using cargo metadata, we make the same change as cargo 1.79 does, but also for older Rust versions, so that Corrosion users can use the same CMake target name independent of the Rust version. Fixes corrosion-rs#501 (cherry-picked from f85b242)
jschwe
force-pushed
the
jschwender/backport_underscore
branch
from
3d6eb13
to
013088d
Compare
|
Released as stable/v0.5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will probably be released as v0.5, since it is a breaking change.