Support more generator expressions in output directories #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jschwe
reviewed
May 9, 2024
| # $<0:true-string> -> | ||
| string(REGEX REPLACE "\\\$<0:([^>]*)>" "" genex "${genex}") | ||
| # $<IF:1,true-string,false-string> -> true-string | ||
| string(REGEX REPLACE "\\\$<IF:1,([^>,]*),([^>]*)>" "\\1" genex "${genex}") |
There was a problem hiding this comment.
Perhaps we could use the cmake raw strings feature, so that you don't need all these escapes: https://cmake.org/cmake/help/latest/manual/cmake-language.7.html#bracket-argument
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows output directories that contain a few more generator expressions than just
$<CONFIG>.Useful if your binary output path contains something like
$<$<CONFIG:Debug>:dbg>, which expands to "dbg" when building for Debug, and empty string otherwise.TODO: Add tests