Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to decorators #6

Merged
merged 13 commits into from Jul 29, 2018
Merged

Refactor to decorators #6

merged 13 commits into from Jul 29, 2018

Conversation

Lodin
Copy link
Member

@Lodin Lodin commented Jul 29, 2018

Refactor whole project to use decorators as a preparation to upcoming decorators proposal. Unfortunately, due to decorators unability to change class type some typings became more complex to use. E.g. to use routeResolving of @outlet it is necessary to cast class to any:

@outlet(routes)
class RouterOutlet extends HTMLElement {
  public async waitForRouterResolving(): Promise<void> {
    await (this as any).routeResolving;
  }
}

@Lodin Lodin merged commit 1f25a5e into master Jul 29, 2018
@Lodin Lodin mentioned this pull request Jul 29, 2018
@Lodin Lodin deleted the refactor/decorators branch October 1, 2018 04:59
@Lodin Lodin self-assigned this Dec 30, 2018
Lodin added a commit that referenced this pull request Feb 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant