Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dependencies #707

Merged
merged 20 commits into from
Aug 27, 2022
Merged

Bump dependencies #707

merged 20 commits into from
Aug 27, 2022

Conversation

benjamin-shen
Copy link
Collaborator

Summary

This pull request bumps a bunch of dependencies for security reasons & ci/cd fixes.

  • firebase web v8 => web v9 (this resulted in the majority of code changes)
  • removed definitely-unused dependencies

Remaining TODOs:

  • firestore syntax changes in scripts, if necessary
  • remove vue 2 dependencies (see if we can remove bootstrap-vue, relevant issue)

Test Plan

Check out to this PR, rm -rf node_modules, npm install, npm run serve, sanity check local app.
Do the same with the functions/ directory and check that nothing seemed to break.

Breaking Changes

  • Everyone will need to update dependencies on their machines, npm install --force.

@benjamin-shen benjamin-shen requested a review from a team as a code owner August 27, 2022 03:29
@dti-github-bot
Copy link
Member

[diff-counting] Significant lines: 248.

@github-actions
Copy link
Contributor

Visit the preview URL for this PR (updated for commit 05246be):

https://cornelldti-courseplan-dev--pr707-ben-fa22-dependencie-6i523bkq.web.app

(expires Mon, 26 Sep 2022 03:32:16 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@benjamin-shen benjamin-shen changed the title Ben/fa22 dependencies Bump dependencies Aug 27, 2022
import 'firebase/auth';
import 'firebase/database';
import 'firebase/firestore';
import firebase from 'firebase/compat/app';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much Ben for updating our firebase code to the modular Web SDK! Is there any reason we still need to use the version 8 SDK through compat for cypress?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's what's suggested by the readme for cypress-firebase (look for "SDK version 9"). I imagine this is so their versions are backwards/forwards-compatible and their implementation can keep using the version 8 SDK.

@zachary-kent
Copy link
Collaborator

I agree that we should remove the functions directory though, most of the scripts there fail because there aren't any firebase functions actually implemented.

@benjamin-shen benjamin-shen merged commit 224aa19 into master Aug 27, 2022
@benjamin-shen benjamin-shen deleted the ben/fa22-dependencies branch August 27, 2022 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants