-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump dependencies #707
Bump dependencies #707
Conversation
[diff-counting] Significant lines: 248. |
Visit the preview URL for this PR (updated for commit 05246be): https://cornelldti-courseplan-dev--pr707-ben-fa22-dependencie-6i523bkq.web.app (expires Mon, 26 Sep 2022 03:32:16 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
import 'firebase/auth'; | ||
import 'firebase/database'; | ||
import 'firebase/firestore'; | ||
import firebase from 'firebase/compat/app'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much Ben for updating our firebase code to the modular Web SDK! Is there any reason we still need to use the version 8 SDK through compat
for cypress?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's what's suggested by the readme for cypress-firebase (look for "SDK version 9"). I imagine this is so their versions are backwards/forwards-compatible and their implementation can keep using the version 8 SDK.
I agree that we should remove the |
Summary
This pull request bumps a bunch of dependencies for security reasons & ci/cd fixes.
Remaining TODOs:
bootstrap-vue
, relevant issue)Test Plan
Check out to this PR,
rm -rf node_modules
,npm install
,npm run serve
, sanity check local app.Do the same with the
functions/
directory and check that nothing seemed to break.Breaking Changes
npm install --force
.