Commits on Dec 13, 2021

1. importer: Canonicalize chkconfig symlink target …

   This is a build-side fix for `chkconfig` shipping a non-canonical symlink;
   see:
   ostreedev/ostree-rs-ext#182
   
   I'll copy/paste that commit message:
   
   In https://github.com/ostreedev/ostree we generate a cryptographic
   checksum over files and symlinks, and directories.
   
   ostree does not currently perform any canonicalization on symlinks;
   we'll respect and honor whatever bytes we're provided as input,
   and replicate that on the target.
   
   We're using the Rust tar crate to do tar serialization,
   which has so far worked fine...except, I hit this corner case:
   
   ```
   [root@cosa-devsh ~]# rpm -qf /usr/lib/systemd/systemd-sysv-install
   chkconfig-1.13-2.el8.x86_64
   [root@cosa-devsh ~]# ll /usr/lib/systemd/systemd-sysv-install
   lrwxrwxrwx. 2 root root 24 Nov 29 18:08 /usr/lib/systemd/systemd-sysv-install -> ../../..//sbin/chkconfig
   [root@cosa-devsh ~]#
   ```
   
   But, using `set_link_name` to write the tarball, we end up with
   the canonicalized path `../../../sbin/chkconfig` - i.e. without the
   double `//`.  This breaks the checksum.
   
   Now, I am a bit tempted to change ostree to do canonicalization.  But
   even if we did, I'd need to *exactly* match what tar-rs is doing.
   
   (I may of course also try to change the rhel8 systemd package, but
    that's going to take a while to propagate and this corner case isn't
    the only one I'm sure)
   
   I verified that this fixes `rpm-ostree ex-container encapsulate`
   for RHCOS.
   
   In fact, it is *just that* one systemd symlink which is non-canonical.

   

   cgwalters committed Dec 13, 2021
   Configuration menu

   • View commit details
   • Copy full SHA for d8b0e8f
   • Browse repository at this point

   Copy the full SHA

   d8b0e8f View commit details

   Browse the repository at this point in the history