Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to clap 4.1 #1021

Merged
merged 6 commits into from Jun 8, 2023
Merged

Update to clap 4.1 #1021

merged 6 commits into from Jun 8, 2023

Conversation

bgilbert
Copy link
Contributor

@bgilbert bgilbert commented Oct 21, 2022

No description provided.

@bgilbert bgilbert added the msrv Needs newer MSRV label Oct 21, 2022
@bgilbert bgilbert changed the title WIP: Update to clap 4 WIP: Update to clap 4.1 Jan 13, 2023
@bgilbert
Copy link
Contributor Author

clap 4.1 fixes the multiline help text regression, so I've updated to it. Unfortunately it also bumps the MSRV to 1.64.

@bgilbert bgilbert removed the msrv Needs newer MSRV label May 23, 2023
@bgilbert bgilbert changed the title WIP: Update to clap 4.1 Update to clap 4.1 Jun 8, 2023
DeriveDisplayOrder is now the default.

Argument dependencies are now specified by the struct field name rather
than the argument's long name.

require_value_delimiter has been removed and we can simplify the
configuration on affected parameters.

Help sections are now title case.
@bgilbert bgilbert marked this pull request as ready for review June 8, 2023 15:27
@bgilbert
Copy link
Contributor Author

bgilbert commented Jun 8, 2023

Ready for review!

@bgilbert bgilbert requested a review from prestist June 8, 2023 15:28
Copy link
Contributor

@prestist prestist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bgilbert bgilbert merged commit 777b976 into coreos:main Jun 8, 2023
14 checks passed
@bgilbert bgilbert deleted the clap branch June 8, 2023 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants