GO linting bump and removal of deprecated linters #5624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tantalor93
requested review from
miekg,
chrisohaver,
johnbelamaric,
yongtang,
stp-ip,
bradbeam,
dilyevsky,
jameshartig,
greenpau,
Isolus,
pmoroney,
rajansandeep and
SuperQ
as code owners
Signed-off-by: Ondřej Benkovský <ondrej.benkovsky@jamf.com>
Signed-off-by: Ondřej Benkovský <ondrej.benkovsky@jamf.com>
Codecov Report
@@ Coverage Diff @@
## master #5624 +/- ##
==========================================
+ Coverage 55.70% 56.88% +1.17%
==========================================
Files 224 243 +19
Lines 10016 15610 +5594
==========================================
+ Hits 5579 8879 +3300
- Misses 3978 6188 +2210
- Partials 459 543 +84
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
yongtang
approved these changes
Sep 19, 2022
gonzalop
pushed a commit
to gonzalop/coredns
that referenced
this pull request
Jan 14, 2023
* bump golangci-lint with support of go 1.19 Signed-off-by: Ondřej Benkovský <ondrej.benkovsky@jamf.com> * remove deprecated usage of varcheck, deadcode, and structcheck Signed-off-by: Ondřej Benkovský <ondrej.benkovsky@jamf.com> Signed-off-by: Ondřej Benkovský <ondrej.benkovsky@jamf.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Why is this pull request needed and what does it do?
bumps golangci-lint to 1.49.0 and also remove workaround for supporting Go 1.19 and removes usage of deprecated linters (deadcode, structcheck, varcheck)
2. Which issues (if any) are related?
none
3. Which documentation changes (if any) need to be made?
none
4. Does this introduce a backward incompatible change or deprecation?
no