server: Ignore net.ErrClosed errors when shutting down #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also make server.Wait wait for all the listeners to exit, instead of returning when the first one closes, which we couldn't do before because of the spurious errors it would return errors.Join requires go 1.20, update go.mod Fixes coredhcp#103 Signed-off-by: Anatole Denis <anatole@unverle.fr>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #189 +/- ##
==========================================
- Coverage 42.84% 42.62% -0.23%
==========================================
Files 24 24
Lines 1335 1342 +7
==========================================
Hits 572 572
- Misses 674 679 +5
- Partials 89 91 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pmazzini
approved these changes
May 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #103
Also make
server.Waitwait for all the listeners to exit, instead of returning when the first one closes, which we couldn't do before because of the spurious errors it would return - this ensures that the server is completely shut down whenserver.Waitreturns, instead of potentially still having listeners answering their last requests.errors.Joinrequires go 1.20, update go.mod accordingly. CI already runs on 1.20 and up only so doesn't need changes