Disallow implicit re-exports of imported values in Python modules #636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fpinto-cdd
force-pushed
the
task/disallow-implicit-re-exports-of-imported-values-in-python-modules
branch
2 times, most recently
from
be1d1c2
to
26d9b1a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #636 +/- ##
===========================================
+ Coverage 86.98% 87.00% +0.01%
===========================================
Files 34 34
Lines 3013 3016 +3
Branches 378 378
===========================================
+ Hits 2621 2624 +3
Misses 250 250
Partials 142 142 ☔ View full report in Codecov by Sentry. |
jtrobles-cdd
requested changes
May 15, 2024
fpinto-cdd
force-pushed
the
task/disallow-implicit-re-exports-of-imported-values-in-python-modules
branch
from
26d9b1a
to
e6281e6
Compare
- Set Mypy option `no_implicit_reexport` to `True`. - Fix errors reported by Mypy after the configuration change. From https://mypy.readthedocs.io/en/stable/command_line.html#cmdoption-mypy-no-implicit-reexport: > […] [do] not re-export unless the item is imported using from-as or is included in `__all__`. Ref: https://app.shortcut.com/cordada/story/6589 [sc-6589]
fpinto-cdd
force-pushed
the
task/disallow-implicit-re-exports-of-imported-values-in-python-modules
branch
from
e6281e6
to
cbb5002
Compare
|
jtrobles-cdd
approved these changes
May 15, 2024
fpinto-cdd
deleted the
task/disallow-implicit-re-exports-of-imported-values-in-python-modules
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no_implicit_reexporttoTrue.From https://mypy.readthedocs.io/en/stable/command_line.html#cmdoption-mypy-no-implicit-reexport:
Ref: https://app.shortcut.com/cordada/story/6589 [sc-6589]