Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use rustls in reqwest dep #2385

Closed
wants to merge 6 commits into from
Closed

Conversation

kevinheavey
Copy link
Contributor

@kevinheavey kevinheavey commented Feb 3, 2023

This should remove the need for libssl, or at least remove two things that require it

@vercel
Copy link

vercel bot commented Feb 3, 2023

@kevinheavey is attempting to deploy a commit to the coral-xyz Team on Vercel.

A member of the Team first needs to authorize it.

@Henry-E
Copy link
Contributor

Henry-E commented Feb 3, 2023

Great, so these changes just narrow down the features that anchor uses? Can you say more about what rustls is. Is this worthy of a changelog?

@kevinheavey
Copy link
Contributor Author

The default native-tls feature of reqwest relies on OpenSSL being installed, which is not something Cargo can take care of for you (hence why the Anchor docs tell you to install a bunch of Linux packages). rustls not the default because it results in bigger binaries and is less mature.

Solana crates like cargo-build-bpf already use the rustls feature though so I'm not worried about those disadvantages.

A changelog entry would be good so people can take a step out of their workflows if needed

@Henry-E
Copy link
Contributor

Henry-E commented Feb 6, 2023

Ok, well if it's good enough for cargo-build-bpf, then it's probably good enough for us.

@vercel
Copy link

vercel bot commented Feb 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
anchor-docs ⬜️ Ignored (Inspect) Feb 6, 2023 at 6:23PM (UTC)

@Henry-E Henry-E closed this Feb 6, 2023
@Henry-E Henry-E reopened this Feb 6, 2023
@Henry-E
Copy link
Contributor

Henry-E commented Feb 6, 2023

Merge attempt failed
Changes must be made through a pull request.

Getting this error when trying to squash and merge. Very odd

@Henry-E
Copy link
Contributor

Henry-E commented Feb 7, 2023

Github keeps erroring when trying to merge this PR, so just going to remake it in a new PR and merge that instead.

@Henry-E Henry-E closed this Feb 7, 2023
@Henry-E Henry-E mentioned this pull request Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants